From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: move the check for post-EOF mappings into xfs_can_free_eofblocks
Date: Fri, 19 Mar 2021 06:35:37 +0000 [thread overview]
Message-ID: <20210319063537.GB965589@infradead.org> (raw)
In-Reply-To: <20210319060534.GF1670408@magnolia>
On Thu, Mar 18, 2021 at 11:05:34PM -0700, Darrick J. Wong wrote:
> xfs_inactive doesn't take the iolock because (evidently) at some point
> there were lockdep complaints about taking it in reclaim context. By
> the time the inode reaches inactivation context, there can't be any
> other users of it anyway -- the last caller dropped its reference, we
> tore down the VFS inode, and anyone who wants to resuscitate the inode
> will wait in xfs_iget for us to finish.
Yes. What I meant is that if we can deduce that we are in inactive
somehow (probably using the VFS inode state) we can ASSERT that we
are either in inactive or hold the iolock.
next prev parent reply other threads:[~2021-03-19 6:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 22:33 [PATCHSET 0/2] xfs: make xfs_can_free_eofblocks a predicate Darrick J. Wong
2021-03-18 22:33 ` [PATCH 1/2] xfs: move the xfs_can_free_eofblocks call under the IOLOCK Darrick J. Wong
2021-03-19 5:53 ` Christoph Hellwig
2021-03-19 6:01 ` Darrick J. Wong
2021-03-19 6:31 ` Christoph Hellwig
2021-03-18 22:33 ` [PATCH 2/2] xfs: move the check for post-EOF mappings into xfs_can_free_eofblocks Darrick J. Wong
2021-03-19 5:59 ` Christoph Hellwig
2021-03-19 6:05 ` Darrick J. Wong
2021-03-19 6:35 ` Christoph Hellwig [this message]
2021-03-19 16:59 ` Darrick J. Wong
2021-03-23 18:32 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2021-03-26 0:20 [PATCHSET v2 0/2] xfs: make xfs_can_free_eofblocks a predicate Darrick J. Wong
2021-03-26 0:21 ` [PATCH 2/2] xfs: move the check for post-EOF mappings into xfs_can_free_eofblocks Darrick J. Wong
2021-03-26 6:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319063537.GB965589@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox