Re: [PATCH 01/11] xfs: prevent metadata files from being inactivated

Dave Chinner
2021-03-22T23:14:00Z

On Wed, Mar 10, 2021 at 07:05:46PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Files containing metadata (quota records, rt bitmap and summary info)
> are fully managed by the filesystem, which means that all resource
> cleanup must be explicit, not automatic. This means that they should
> never be subjected automatic to post-eof truncation, nor should they be
> freed automatically even if the link count drops to zero.
>
> In other words, xfs_inactive() should leave these files alone. Add the
> necessary predicate functions to make this happen. This adds a second
> layer of prevention for the kinds of fs corruption that was fixed by
> commit f4c32e87de7d. If we ever decide to support removing metadata
> files, we should make all those metadata updates explicit.
>
> Rearrange the order of #includes to fix compiler errors, since
> xfs_mount.h is supposed to be included before xfs_inode.h
>
> Followup-to: f4c32e87de7d ("xfs: fix realtime bitmap/summary file truncation when growing rt volume")
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>

looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com