From: Christoph Hellwig <hch@infradead.org>
To: Chandan Babu R <chandanrlinux@gmail.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: Use struct xfs_bmdr_block instead of struct xfs_btree_block to calculate root node size
Date: Fri, 2 Apr 2021 07:43:12 +0100 [thread overview]
Message-ID: <20210402064312.GA1739272@infradead.org> (raw)
In-Reply-To: <20210401164525.8638-1-chandanrlinux@gmail.com>
On Thu, Apr 01, 2021 at 10:15:25PM +0530, Chandan Babu R wrote:
> @@ -927,13 +927,16 @@ xfs_bmap_add_attrfork_btree(
> xfs_inode_t *ip, /* incore inode pointer */
> int *flags) /* inode logging flags */
> {
> + struct xfs_btree_block *block;
> xfs_btree_cur_t *cur; /* btree cursor */
> int error; /* error return value */
> xfs_mount_t *mp; /* file system mount struct */
> int stat; /* newroot status */
>
> mp = ip->i_mount;
> - if (ip->i_df.if_broot_bytes <= XFS_IFORK_DSIZE(ip))
> + block = ip->i_df.if_broot;
Just initializing block o nthe line it is declared would read a little
easier. Other than that this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-04-02 6:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 16:45 [PATCH] xfs: Use struct xfs_bmdr_block instead of struct xfs_btree_block to calculate root node size Chandan Babu R
2021-04-02 6:43 ` Christoph Hellwig [this message]
2021-04-02 11:51 ` [PATCH V1.1] " Chandan Babu R
2021-04-02 15:39 ` Darrick J. Wong
2021-04-03 15:51 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210402064312.GA1739272@infradead.org \
--to=hch@infradead.org \
--cc=chandanrlinux@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).