From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2 2/3] xfs: transaction subsystem quiesce mechanism
Date: Wed, 7 Apr 2021 14:24:55 +0100 [thread overview]
Message-ID: <20210407132455.GA3459356@infradead.org> (raw)
In-Reply-To: <YG2ZRXp/vPXlvpcB@bfoster>
On Wed, Apr 07, 2021 at 07:36:37AM -0400, Brian Foster wrote:
> Personally, I'd probably have to think about it some more, but initially
> I don't have any strong objection to removing quotaoff support. More
> practically, I suspect we'd have to deprecate it for some period of time
> given that it's a generic interface, has userspace tools, regression
> tests, etc., and may or may not have real users who might want the
> opportunity to object (or adjust).
>
> Though perhaps potentially avoiding that mess is what you mean by "...
> disables accounting vs. enforcement." I.e., retain the interface and
> general ability to turn off enforcement, but require a mount cycle in
> the future to disable accounting..? Hmm... that seems like a potentially
> nicer/easier path forward and a less disruptive change. I wonder even if
> we could just (eventually) ignore the accounting disablement flags from
> userspace and if any users would have reason to care about that change
> in behavior.
I'm currently testing a series that just ignores disabling of accounting
and logs a message and that seems to do ok so far. I'll check if
clearing the on-disk flags as well could work out even better.
next prev parent reply other threads:[~2021-04-07 13:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 14:42 [PATCH v2 0/3] xfs: rework quotaoff to avoid log deadlock Brian Foster
2021-04-06 14:42 ` [PATCH v2 1/3] xfs: skip dquot reservations if quota is inactive Brian Foster
2021-04-07 7:58 ` Christoph Hellwig
2021-04-07 15:51 ` Darrick J. Wong
2021-04-06 14:42 ` [PATCH v2 2/3] xfs: transaction subsystem quiesce mechanism Brian Foster
2021-04-07 8:00 ` Christoph Hellwig
2021-04-07 11:36 ` Brian Foster
2021-04-07 13:24 ` Christoph Hellwig [this message]
2021-04-07 15:50 ` Darrick J. Wong
2021-04-06 14:42 ` [PATCH v2 3/3] xfs: rework quotaoff logging to avoid log deadlock on active fs Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407132455.GA3459356@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).