From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45663C433ED for ; Wed, 7 Apr 2021 15:24:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 163F661262 for ; Wed, 7 Apr 2021 15:24:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231818AbhDGPYB (ORCPT ); Wed, 7 Apr 2021 11:24:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:37570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353483AbhDGPXn (ORCPT ); Wed, 7 Apr 2021 11:23:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 31FEF61007; Wed, 7 Apr 2021 15:23:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617809014; bh=36BhoV8y18nQyobSa0n4cK/hp9uQtTozwmInF8Qz85I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GhRjJ9KDWFanHDo/NouTSMMtAO1QGM2ZhIoyJh30UuBd57ZYDMRZqYlsRTWm0UedM UlOPu8g7DMhDIsAasuAk/+iQdyX821TWcI9E3Tz1B0zsDZzNnJqhy3BbAGyJHJWJti YMoVjuFunKQj7bRu24MrnEx0/xApkFn0MVNdhLBuZl1CjBvC7HjIWjSs9/selquV3f zVuBsPDtoD8enIgW0rMcm6DH/b5CU7U5wDQEmF9PJXjY1+DrQqV58rfcUY8nnimOBf /42SCUnxbScBRtW4X0H/Erl3aUiijoeJz7iIgBgo4e3l4F3CXd0F9gDpCi3Yzl0DJg 09YMEW2IyWxRQ== Date: Wed, 7 Apr 2021 08:23:34 -0700 From: "Darrick J. Wong" To: Brian Foster Cc: Christoph Hellwig , linux-xfs@vger.kernel.org Subject: Re: [PATCH 2/4] xfs: open code ioend needs workqueue helper Message-ID: <20210407152334.GH3957620@magnolia> References: <20210405145903.629152-1-bfoster@redhat.com> <20210405145903.629152-3-bfoster@redhat.com> <20210407063440.GC3339217@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Apr 07, 2021 at 07:24:13AM -0400, Brian Foster wrote: > On Wed, Apr 07, 2021 at 07:34:40AM +0100, Christoph Hellwig wrote: > > On Mon, Apr 05, 2021 at 10:59:01AM -0400, Brian Foster wrote: > > > Open code xfs_ioend_needs_workqueue() into the only remaining > > > caller. > > > > This description would all fit on a single line. > > > > I've used 68 character wide commit log descriptions for quite some time, > to which this seems to be wrapped accurately. This is the same as the > immediately previous patch for example, with the much longer > description. I don't care much about changing it, but is there a > canonical format defined somewhere? I've always just thought 68-72 was > acceptable. I set email to wrap at 72 and C code to wrap at 79 columns. Though as I've said in the past, I don't enforce /any/ of those rules with any specificity so long as they're not being abused. (e.g. wrapping at column 5 or 500) --D > Brian > > > Looks good: > > > > Reviewed-by: Christoph Hellwig > > >