From: Chandan Babu R <chandanrlinux@gmail.com>
To: fstests@vger.kernel.org
Cc: Chandan Babu R <chandanrlinux@gmail.com>,
linux-xfs@vger.kernel.org, djwong@kernel.org
Subject: [PATCH] fstests: Disable realtime inherit flag when executing xfs/{532,533,538}
Date: Fri, 9 Apr 2021 18:19:03 +0530 [thread overview]
Message-ID: <20210409124903.23374-1-chandanrlinux@gmail.com> (raw)
The minimum length space allocator (i.e. xfs_bmap_exact_minlen_extent_alloc())
depends on the underlying filesystem to be fragmented so that there are enough
one block sized extents available to satify space allocation requests.
xfs/{532,533,538} tests issue space allocation requests for metadata (e.g. for
blocks holding directory and xattr information). With realtime filesystem
instances, these tests would end up fragmenting the space on realtime
device. Hence minimum length space allocator fails since the regular
filesystem space is not fragmented and hence there are no one block sized
extents available.
Thus, this commit disables realtime inherit flag (if any) on root directory so
that space on data device gets fragmented rather than realtime device.
Suggested-by: Darrick J. Wong <djwong@kernel.org>
Reported-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
---
tests/xfs/532 | 4 ++++
tests/xfs/533 | 4 ++++
tests/xfs/538 | 4 ++++
3 files changed, 12 insertions(+)
diff --git a/tests/xfs/532 b/tests/xfs/532
index 2bed574a..560af586 100755
--- a/tests/xfs/532
+++ b/tests/xfs/532
@@ -45,6 +45,10 @@ echo "Format and mount fs"
_scratch_mkfs_sized $((1024 * 1024 * 1024)) >> $seqres.full
_scratch_mount >> $seqres.full
+# Disable realtime inherit flag (if any) on root directory so that space on data
+# device gets fragmented rather than realtime device.
+$XFS_IO_PROG -c 'chattr -t' $SCRATCH_MNT
+
bsize=$(_get_block_size $SCRATCH_MNT)
attr_len=255
diff --git a/tests/xfs/533 b/tests/xfs/533
index be909fcc..dd4cb4c4 100755
--- a/tests/xfs/533
+++ b/tests/xfs/533
@@ -56,6 +56,10 @@ echo "Format and mount fs"
_scratch_mkfs_sized $((1024 * 1024 * 1024)) >> $seqres.full
_scratch_mount >> $seqres.full
+# Disable realtime inherit flag (if any) on root directory so that space on data
+# device gets fragmented rather than realtime device.
+$XFS_IO_PROG -c 'chattr -t' $SCRATCH_MNT
+
echo "Consume free space"
fillerdir=$SCRATCH_MNT/fillerdir
nr_free_blks=$(stat -f -c '%f' $SCRATCH_MNT)
diff --git a/tests/xfs/538 b/tests/xfs/538
index 90eb1637..97273b88 100755
--- a/tests/xfs/538
+++ b/tests/xfs/538
@@ -42,6 +42,10 @@ echo "Format and mount fs"
_scratch_mkfs_sized $((1024 * 1024 * 1024)) >> $seqres.full
_scratch_mount >> $seqres.full
+# Disable realtime inherit flag (if any) on root directory so that space on data
+# device gets fragmented rather than realtime device.
+$XFS_IO_PROG -c 'chattr -t' $SCRATCH_MNT
+
bsize=$(_get_file_block_size $SCRATCH_MNT)
echo "Consume free space"
--
2.29.2
next reply other threads:[~2021-04-09 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 12:49 Chandan Babu R [this message]
2021-04-09 15:19 ` [PATCH] fstests: Disable realtime inherit flag when executing xfs/{532,533,538} Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409124903.23374-1-chandanrlinux@gmail.com \
--to=chandanrlinux@gmail.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).