From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 702E6C433B4 for ; Wed, 14 Apr 2021 15:29:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D586611B0 for ; Wed, 14 Apr 2021 15:29:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233788AbhDNP3w (ORCPT ); Wed, 14 Apr 2021 11:29:52 -0400 Received: from verein.lst.de ([213.95.11.211]:59307 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352306AbhDNP3p (ORCPT ); Wed, 14 Apr 2021 11:29:45 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 410C868C7B; Wed, 14 Apr 2021 17:29:21 +0200 (CEST) Date: Wed, 14 Apr 2021 17:29:21 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , linux-xfs@vger.kernel.org Subject: Re: [PATCH 7/7] xfs: remove XFS_IFEXTENTS Message-ID: <20210414152921.GA31516@lst.de> References: <20210412133819.2618857-1-hch@lst.de> <20210412133819.2618857-8-hch@lst.de> <20210414003744.GU3957620@magnolia> <20210414055923.GA24575@lst.de> <20210414152718.GB3957620@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414152718.GB3957620@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Apr 14, 2021 at 08:27:18AM -0700, Darrick J. Wong wrote: > On Wed, Apr 14, 2021 at 07:59:23AM +0200, Christoph Hellwig wrote: > > On Tue, Apr 13, 2021 at 05:37:44PM -0700, Darrick J. Wong wrote: > > > Seeing how we already had a go-round where Dave and stumbled > > > over each other about the somewhat duplicative flags and format fields > > > I'm inclined to take this sooner or later just to eliminate the > > > ambiguity... > > > > Do you want me to resend for the comment that Brian wants to see, or > > do you want to just fold that in? > > Hm? I thought Brian was describing a comment that's already in > xfs_btree_staging.c around line 195 as his reason for adding an RVB? Oh, indeed. I somehow misread his mail as asking to add this comment.