From: Allison Henderson <allison.henderson@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v17 05/11] xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete
Date: Fri, 16 Apr 2021 02:20:39 -0700 [thread overview]
Message-ID: <20210416092045.2215-6-allison.henderson@oracle.com> (raw)
In-Reply-To: <20210416092045.2215-1-allison.henderson@oracle.com>
This patch separate xfs_attr_node_addname into two functions. This will
help to make it easier to hoist parts of xfs_attr_node_addname that need
state management
Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
---
fs/xfs/libxfs/xfs_attr.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
index fff1c6f..d9dfc8d2 100644
--- a/fs/xfs/libxfs/xfs_attr.c
+++ b/fs/xfs/libxfs/xfs_attr.c
@@ -54,6 +54,7 @@ STATIC int xfs_attr_leaf_hasname(struct xfs_da_args *args, struct xfs_buf **bp);
STATIC int xfs_attr_node_get(xfs_da_args_t *args);
STATIC int xfs_attr_node_addname(xfs_da_args_t *args);
STATIC int xfs_attr_node_removename(xfs_da_args_t *args);
+STATIC int xfs_attr_node_addname_clear_incomplete(struct xfs_da_args *args);
STATIC int xfs_attr_node_hasname(xfs_da_args_t *args,
struct xfs_da_state **state);
STATIC int xfs_attr_fillstate(xfs_da_state_t *state);
@@ -1062,6 +1063,25 @@ xfs_attr_node_addname(
return error;
}
+ error = xfs_attr_node_addname_clear_incomplete(args);
+out:
+ if (state)
+ xfs_da_state_free(state);
+ if (error)
+ return error;
+ return retval;
+}
+
+
+STATIC
+int xfs_attr_node_addname_clear_incomplete(
+ struct xfs_da_args *args)
+{
+ struct xfs_da_state *state = NULL;
+ struct xfs_da_state_blk *blk;
+ int retval = 0;
+ int error = 0;
+
/*
* Re-find the "old" attribute entry after any split ops. The INCOMPLETE
* flag means that we will find the "old" attr, not the "new" one.
--
2.7.4
next prev parent reply other threads:[~2021-04-16 9:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 9:20 [PATCH v17 00/11] xfs: Delay Ready Attributes Allison Henderson
2021-04-16 9:20 ` [PATCH v17 01/11] xfs: Reverse apply 72b97ea40d Allison Henderson
2021-04-16 9:20 ` [PATCH v17 02/11] xfs: Add xfs_attr_node_remove_cleanup Allison Henderson
2021-04-16 9:20 ` [PATCH v17 03/11] xfs: Hoist xfs_attr_set_shortform Allison Henderson
2021-04-16 9:20 ` [PATCH v17 04/11] xfs: Add helper xfs_attr_set_fmt Allison Henderson
2021-04-16 9:20 ` Allison Henderson [this message]
2021-04-19 5:15 ` [PATCH v17 05/11] xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete Chandan Babu R
2021-04-19 18:32 ` Allison Henderson
2021-04-20 12:14 ` Chandan Babu R
2021-04-20 17:41 ` Allison Henderson
2021-04-16 9:20 ` [PATCH v17 06/11] xfs: Add helper xfs_attr_node_addname_find_attr Allison Henderson
2021-04-16 9:20 ` [PATCH v17 07/11] xfs: Hoist xfs_attr_node_addname Allison Henderson
2021-04-19 5:31 ` Chandan Babu R
2021-04-19 18:32 ` Allison Henderson
2021-04-16 9:20 ` [PATCH v17 08/11] xfs: Hoist xfs_attr_leaf_addname Allison Henderson
2021-04-23 17:06 ` Brian Foster
2021-04-24 3:26 ` Allison Henderson
2021-04-16 9:20 ` [PATCH v17 09/11] xfs: Hoist node transaction handling Allison Henderson
2021-04-16 9:20 ` [PATCH v17 10/11] xfs: Add delay ready attr remove routines Allison Henderson
2021-04-19 6:53 ` Chandan Babu R
2021-04-19 18:32 ` Allison Henderson
2021-04-23 17:06 ` Brian Foster
2021-04-24 3:27 ` Allison Henderson
2021-04-24 15:56 ` Darrick J. Wong
2021-04-26 11:49 ` Brian Foster
2021-04-26 16:52 ` Allison Henderson
2021-04-16 9:20 ` [PATCH v17 11/11] xfs: Add delay ready attr set routines Allison Henderson
2021-04-23 19:08 ` Brian Foster
2021-04-24 3:27 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416092045.2215-6-allison.henderson@oracle.com \
--to=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox