From: Christoph Hellwig <hch@lst.de>
To: linux-xfs@vger.kernel.org
Cc: "Gustavo A . R . Silva" <gustavoars@kernel.org>
Subject: [PATCH 3/7] xfs: pass a xfs_efi_log_item to xfs_efi_item_sizeof
Date: Mon, 19 Apr 2021 10:28:00 +0200 [thread overview]
Message-ID: <20210419082804.2076124-4-hch@lst.de> (raw)
In-Reply-To: <20210419082804.2076124-1-hch@lst.de>
xfs_efi_log_item only looks at the embedded xfs_efi_log_item structure,
so pass that directly and rename the function to xfs_efi_log_item_sizeof.
This allows using the helper in xlog_recover_efi_commit_pass2 as well.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_extfree_item.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/fs/xfs/xfs_extfree_item.c b/fs/xfs/xfs_extfree_item.c
index ed8d0790908ea7..7ae570d1944590 100644
--- a/fs/xfs/xfs_extfree_item.c
+++ b/fs/xfs/xfs_extfree_item.c
@@ -70,11 +70,11 @@ xfs_efi_release(
* structure.
*/
static inline int
-xfs_efi_item_sizeof(
- struct xfs_efi_log_item *efip)
+xfs_efi_log_item_sizeof(
+ struct xfs_efi_log_format *elf)
{
- return sizeof(struct xfs_efi_log_format) +
- (efip->efi_format.efi_nextents - 1) * sizeof(struct xfs_extent);
+ return sizeof(*elf) +
+ (elf->efi_nextents - 1) * sizeof(struct xfs_extent);
}
STATIC void
@@ -84,7 +84,7 @@ xfs_efi_item_size(
int *nbytes)
{
*nvecs += 1;
- *nbytes += xfs_efi_item_sizeof(EFI_ITEM(lip));
+ *nbytes += xfs_efi_log_item_sizeof(&EFI_ITEM(lip)->efi_format);
}
/*
@@ -110,7 +110,7 @@ xfs_efi_item_format(
xlog_copy_iovec(lv, &vecp, XLOG_REG_TYPE_EFI_FORMAT,
&efip->efi_format,
- xfs_efi_item_sizeof(efip));
+ xfs_efi_log_item_sizeof(&efip->efi_format));
}
@@ -684,8 +684,7 @@ xlog_recover_efi_commit_pass2(
efip = xfs_efi_init(mp, src->efi_nextents);
- if (buf->i_len != sizeof(*src) +
- (src->efi_nextents - 1) * sizeof(struct xfs_extent)) {
+ if (buf->i_len != xfs_efi_log_item_sizeof(src)) {
error = xfs_efi_copy_format_32(&efip->efi_format, buf);
if (error)
goto out_free_efi;
--
2.30.1
next prev parent reply other threads:[~2021-04-19 8:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 8:27 cleanup the EFI/EFD definitions Christoph Hellwig
2021-04-19 8:27 ` [PATCH 1/7] xfs: remove the EFD size asserts in xlog_recover_efd_commit_pass2 Christoph Hellwig
2021-04-20 16:26 ` Darrick J. Wong
2021-04-19 8:27 ` [PATCH 2/7] xfs: clean up the EFI and EFD log format handling Christoph Hellwig
2021-04-20 17:05 ` Darrick J. Wong
2021-04-21 5:55 ` Christoph Hellwig
2021-04-22 0:19 ` Darrick J. Wong
2021-04-19 8:28 ` Christoph Hellwig [this message]
2021-04-20 17:09 ` [PATCH 3/7] xfs: pass a xfs_efi_log_item to xfs_efi_item_sizeof Darrick J. Wong
2021-04-21 5:56 ` Christoph Hellwig
2021-04-22 0:29 ` Darrick J. Wong
2021-04-19 8:28 ` [PATCH 4/7] xfs: pass a xfs_efd_log_item to xfs_efd_item_sizeof Christoph Hellwig
2021-04-20 17:10 ` Darrick J. Wong
2021-04-19 8:28 ` [PATCH 5/7] xfs: add a xfs_efi_item_sizeof helper Christoph Hellwig
2021-04-20 17:11 ` Darrick J. Wong
2021-04-19 8:28 ` [PATCH 6/7] xfs: add a xfs_efd_item_sizeof helper Christoph Hellwig
2021-04-20 17:12 ` Darrick J. Wong
2021-04-19 8:28 ` [PATCH 7/7] xfs: Replace one-element arrays with flexible-array members Christoph Hellwig
2021-04-20 17:15 ` Darrick J. Wong
2021-04-20 22:16 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419082804.2076124-4-hch@lst.de \
--to=hch@lst.de \
--cc=gustavoars@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox