From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: RFC: don't allow disabling quota accounting on a mounted file system
Date: Wed, 21 Apr 2021 08:26:14 +0200 [thread overview]
Message-ID: <20210421062614.GA29662@lst.de> (raw)
In-Reply-To: <20210420173634.GO3122264@magnolia>
On Tue, Apr 20, 2021 at 10:36:34AM -0700, Darrick J. Wong wrote:
> On Tue, Apr 20, 2021 at 09:22:54AM +0200, Christoph Hellwig wrote:
> > Hi all,
> >
> > disabling quota accounting (vs just enforcement) on a running file system
> > is a fundamentally race and hard to get right operation. It also has
> > very little practical use.
> >
> > This causes xfs/007 xfs/106 xfs/220 xfs/304 xfs/305 to fail, as they
> > specifically test this functionality.
>
> What kind of failures do you get now? Are they all a result of the
> _ACCT flags never going away? Which I guess means that tests expecting
> to get ENOSYS after you turn off _ACCT will now no longer error out?
Sort of. Snipplets of the errors:
xfs/007:
core.nblocks = 1
*** turn off ug quotas
+XFS_QUOTARM: Invalid argument
*** umount
*** Usage after quotarm ***
-core.nblocks = 0
-core.nblocks = 0
+core.nblocks = 1
+core.nblocks = 1
xfs/106:
-User quota are not enabled on SCRATCH_DEV
+User quota state on SCRATCH_MNT (SCRATCH_DEV)
+ Accounting: ON
+ Enforcement: OFF
+ Inode: #131 (2 blocks, 2 extents)
+Blocks grace time: [3 days 01:00:00]
xfs/220:
+XFS_QUOTARM: Invalid argument
xfs/304:
*** turn off project quotas
+Quota already off.
*** umount
xfs/305:
*** turn off project quotas
+Quota already off.
*** done
prev parent reply other threads:[~2021-04-21 6:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 7:22 RFC: don't allow disabling quota accounting on a mounted file system Christoph Hellwig
2021-04-20 7:22 ` [PATCH 1/2] xfs: remove support for " Christoph Hellwig
2021-04-22 14:18 ` [xfs] 44349bf9f5: xfstests.xfs.305.fail kernel test robot
2021-04-26 15:06 ` [PATCH 1/2] xfs: remove support for disabling quota accounting on a mounted file system Brian Foster
2021-04-20 7:22 ` [PATCH 2/2] xfs: remove the active vs running quota differentiation Christoph Hellwig
2021-04-20 17:36 ` RFC: don't allow disabling quota accounting on a mounted file system Darrick J. Wong
2021-04-21 6:26 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421062614.GA29662@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox