public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@redhat.com>
To: linux-xfs@vger.kernel.org, Eric Sandeen <sandeen@sandeen.net>
Cc: Gao Xiang <hsiangkao@redhat.com>, "Darrick J . Wong" <djwong@kernel.org>
Subject: [PATCH] mkfs: warn out the V4 format
Date: Wed, 21 Apr 2021 16:57:16 +0800	[thread overview]
Message-ID: <20210421085716.3144357-1-hsiangkao@redhat.com> (raw)

Kernel commit b96cb835e37c ("xfs: deprecate the V4 format") started
the process of retiring the old format to close off attack surfaces
and to encourage users to migrate onto V5.

This also prints warning to users when mkfs as well.

Suggested-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
---
 mkfs/xfs_mkfs.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 0eac5336..ef09f8b3 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -4022,6 +4022,10 @@ main(
 	validate_extsize_hint(mp, &cli);
 	validate_cowextsize_hint(mp, &cli);
 
+	if (!cli.sb_feat.crcs_enabled)
+		fprintf(stderr,
+_("Deprecated V4 format (-mcrc=0) will not be supported after September 2030.\n"));
+
 	/* Print the intended geometry of the fs. */
 	if (!quiet || dry_run) {
 		struct xfs_fsop_geom	geo;
-- 
2.27.0


             reply	other threads:[~2021-04-21  8:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21  8:57 Gao Xiang [this message]
2021-04-21 15:55 ` [PATCH] mkfs: warn out the V4 format Darrick J. Wong
2021-04-21 16:36   ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210421085716.3144357-1-hsiangkao@redhat.com \
    --to=hsiangkao@redhat.com \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox