public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Allison Henderson <allison.henderson@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v18 02/11] xfs: Add xfs_attr_node_remove_name
Date: Wed, 28 Apr 2021 01:09:10 -0700	[thread overview]
Message-ID: <20210428080919.20331-3-allison.henderson@oracle.com> (raw)
In-Reply-To: <20210428080919.20331-1-allison.henderson@oracle.com>

This patch pulls a new helper function xfs_attr_node_remove_name out
of xfs_attr_node_remove_step.  This helps to modularize
xfs_attr_node_remove_step which will help make the delayed attribute
code easier to follow

Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Brian Foster <bfoster@redhat.com>
---
 fs/xfs/libxfs/xfs_attr.c | 29 ++++++++++++++++++++---------
 1 file changed, 20 insertions(+), 9 deletions(-)

diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
index 190b46d..8a08d5b 100644
--- a/fs/xfs/libxfs/xfs_attr.c
+++ b/fs/xfs/libxfs/xfs_attr.c
@@ -1214,6 +1214,25 @@ int xfs_attr_node_removename_setup(
 	return 0;
 }
 
+STATIC int
+xfs_attr_node_remove_name(
+	struct xfs_da_args	*args,
+	struct xfs_da_state	*state)
+{
+	struct xfs_da_state_blk	*blk;
+	int			retval;
+
+	/*
+	 * Remove the name and update the hashvals in the tree.
+	 */
+	blk = &state->path.blk[state->path.active-1];
+	ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC);
+	retval = xfs_attr3_leaf_remove(blk->bp, args);
+	xfs_da3_fixhashpath(state, &state->path);
+
+	return retval;
+}
+
 /*
  * Remove a name from a B-tree attribute list.
  *
@@ -1226,7 +1245,6 @@ xfs_attr_node_removename(
 	struct xfs_da_args	*args)
 {
 	struct xfs_da_state	*state;
-	struct xfs_da_state_blk	*blk;
 	int			retval, error;
 	struct xfs_inode	*dp = args->dp;
 
@@ -1254,14 +1272,7 @@ xfs_attr_node_removename(
 		if (error)
 			goto out;
 	}
-
-	/*
-	 * Remove the name and update the hashvals in the tree.
-	 */
-	blk = &state->path.blk[ state->path.active-1 ];
-	ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC);
-	retval = xfs_attr3_leaf_remove(blk->bp, args);
-	xfs_da3_fixhashpath(state, &state->path);
+	retval = xfs_attr_node_remove_name(args, state);
 
 	/*
 	 * Check to see if the tree needs to be collapsed.
-- 
2.7.4


  parent reply	other threads:[~2021-04-28  8:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  8:09 [PATCH v18 00/11] Delay Ready Attributes Allison Henderson
2021-04-28  8:09 ` [PATCH v18 01/11] xfs: Reverse apply 72b97ea40d Allison Henderson
2021-04-28  8:09 ` Allison Henderson [this message]
2021-04-28  8:09 ` [PATCH v18 03/11] xfs: Hoist xfs_attr_set_shortform Allison Henderson
2021-04-28  8:09 ` [PATCH v18 04/11] xfs: Add helper xfs_attr_set_fmt Allison Henderson
2021-04-28  8:09 ` [PATCH v18 05/11] xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete Allison Henderson
2021-04-29  7:40   ` Chandan Babu R
2021-04-28  8:09 ` [PATCH v18 06/11] xfs: Add helper xfs_attr_node_addname_find_attr Allison Henderson
2021-04-28  8:09 ` [PATCH v18 07/11] xfs: Hoist xfs_attr_node_addname Allison Henderson
2021-04-28  8:09 ` [PATCH v18 08/11] xfs: Hoist xfs_attr_leaf_addname Allison Henderson
2021-04-28  8:09 ` [PATCH v18 09/11] xfs: Hoist node transaction handling Allison Henderson
2021-04-28  8:09 ` [PATCH v18 10/11] xfs: Add delay ready attr remove routines Allison Henderson
2021-04-29  7:49   ` Chandan Babu R
2021-04-29  7:53   ` Chandan Babu R
2021-04-29 14:07   ` Brian Foster
2021-04-28  8:09 ` [PATCH v18 11/11] xfs: Add delay ready attr set routines Allison Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210428080919.20331-3-allison.henderson@oracle.com \
    --to=allison.henderson@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox