From: kernel test robot <lkp@intel.com>
To: Dave Chinner <david@fromorbit.com>, linux-xfs@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] xfs: remove XFS_ITEM_RELEASE_WHEN_COMMITTED
Date: Tue, 4 May 2021 17:04:00 +0800 [thread overview]
Message-ID: <202105041607.uURlpJ7I-lkp@intel.com> (raw)
In-Reply-To: <20210504042805.50176-1-david@fromorbit.com>
[-- Attachment #1: Type: text/plain, Size: 9677 bytes --]
Hi Dave,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on xfs-linux/for-next]
[also build test ERROR on v5.12 next-20210504]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Dave-Chinner/xfs-remove-XFS_ITEM_RELEASE_WHEN_COMMITTED/20210504-123005
base: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next
config: x86_64-randconfig-a002-20210504 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8f5a2a5836cc8e4c1def2bdeb022e7b496623439)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/49245f53b5151023638e214a6f0817452b67c887
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dave-Chinner/xfs-remove-XFS_ITEM_RELEASE_WHEN_COMMITTED/20210504-123005
git checkout 49245f53b5151023638e214a6f0817452b67c887
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from fs/xfs/xfs_trace.c:22:
>> fs/xfs/xfs_trans.h:104:65: error: expected ';' after top level declarator
xfs_lsn_t xfs_log_item_committed_done(struct xfs_log_item *item)
^
;
1 error generated.
--
In file included from fs/xfs/xfs_file.c:14:
>> fs/xfs/xfs_trans.h:104:65: error: expected ';' after top level declarator
xfs_lsn_t xfs_log_item_committed_done(struct xfs_log_item *item)
^
;
In file included from fs/xfs/xfs_file.c:30:
include/linux/mman.h:156:9: warning: division by zero is undefined [-Wdivision-by-zero]
_calc_vm_trans(flags, MAP_SYNC, VM_SYNC ) |
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/mman.h:133:21: note: expanded from macro '_calc_vm_trans'
: ((x) & (bit1)) / ((bit1) / (bit2))))
^ ~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
--
In file included from fs/xfs/xfs_bmap_item.c:16:
>> fs/xfs/xfs_trans.h:104:65: error: expected ';' after top level declarator
xfs_lsn_t xfs_log_item_committed_done(struct xfs_log_item *item)
^
;
>> fs/xfs/xfs_bmap_item.c:209:3: error: field designator 'iop_comitted' does not refer to any field in type 'const struct xfs_item_ops'; did you mean 'iop_committed'?
.iop_comitted = xfs_log_item_committed_done,
^~~~~~~~~~~~
iop_committed
fs/xfs/xfs_trans.h:73:14: note: 'iop_committed' declared here
xfs_lsn_t (*iop_committed)(struct xfs_log_item *, xfs_lsn_t);
^
>> fs/xfs/xfs_bmap_item.c:209:18: error: incompatible function pointer types initializing 'xfs_lsn_t (*)(struct xfs_log_item *, xfs_lsn_t)' (aka 'long long (*)(struct xfs_log_item *, long long)') with an expression of type 'xfs_lsn_t (struct xfs_log_item *)' (aka 'long long (struct xfs_log_item *)') [-Werror,-Wincompatible-function-pointer-types]
.iop_comitted = xfs_log_item_committed_done,
^~~~~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
--
In file included from fs/xfs/xfs_extfree_item.c:15:
>> fs/xfs/xfs_trans.h:104:65: error: expected ';' after top level declarator
xfs_lsn_t xfs_log_item_committed_done(struct xfs_log_item *item)
^
;
>> fs/xfs/xfs_extfree_item.c:313:3: error: field designator 'iop_comitted' does not refer to any field in type 'const struct xfs_item_ops'; did you mean 'iop_committed'?
.iop_comitted = xfs_log_item_committed_done,
^~~~~~~~~~~~
iop_committed
fs/xfs/xfs_trans.h:73:14: note: 'iop_committed' declared here
xfs_lsn_t (*iop_committed)(struct xfs_log_item *, xfs_lsn_t);
^
>> fs/xfs/xfs_extfree_item.c:313:18: error: incompatible function pointer types initializing 'xfs_lsn_t (*)(struct xfs_log_item *, xfs_lsn_t)' (aka 'long long (*)(struct xfs_log_item *, long long)') with an expression of type 'xfs_lsn_t (struct xfs_log_item *)' (aka 'long long (struct xfs_log_item *)') [-Werror,-Wincompatible-function-pointer-types]
.iop_comitted = xfs_log_item_committed_done,
^~~~~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
--
In file included from fs/xfs/xfs_icreate_item.c:14:
>> fs/xfs/xfs_trans.h:104:65: error: expected ';' after top level declarator
xfs_lsn_t xfs_log_item_committed_done(struct xfs_log_item *item)
^
;
>> fs/xfs/xfs_icreate_item.c:73:3: error: field designator 'iop_comitted' does not refer to any field in type 'const struct xfs_item_ops'; did you mean 'iop_committed'?
.iop_comitted = xfs_log_item_committed_done,
^~~~~~~~~~~~
iop_committed
fs/xfs/xfs_trans.h:73:14: note: 'iop_committed' declared here
xfs_lsn_t (*iop_committed)(struct xfs_log_item *, xfs_lsn_t);
^
>> fs/xfs/xfs_icreate_item.c:73:18: error: incompatible function pointer types initializing 'xfs_lsn_t (*)(struct xfs_log_item *, xfs_lsn_t)' (aka 'long long (*)(struct xfs_log_item *, long long)') with an expression of type 'xfs_lsn_t (struct xfs_log_item *)' (aka 'long long (struct xfs_log_item *)') [-Werror,-Wincompatible-function-pointer-types]
.iop_comitted = xfs_log_item_committed_done,
^~~~~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
--
In file included from fs/xfs/xfs_refcount_item.c:15:
>> fs/xfs/xfs_trans.h:104:65: error: expected ';' after top level declarator
xfs_lsn_t xfs_log_item_committed_done(struct xfs_log_item *item)
^
;
>> fs/xfs/xfs_refcount_item.c:214:3: error: field designator 'iop_comitted' does not refer to any field in type 'const struct xfs_item_ops'; did you mean 'iop_committed'?
.iop_comitted = xfs_log_item_committed_done,
^~~~~~~~~~~~
iop_committed
fs/xfs/xfs_trans.h:73:14: note: 'iop_committed' declared here
xfs_lsn_t (*iop_committed)(struct xfs_log_item *, xfs_lsn_t);
^
>> fs/xfs/xfs_refcount_item.c:214:18: error: incompatible function pointer types initializing 'xfs_lsn_t (*)(struct xfs_log_item *, xfs_lsn_t)' (aka 'long long (*)(struct xfs_log_item *, long long)') with an expression of type 'xfs_lsn_t (struct xfs_log_item *)' (aka 'long long (struct xfs_log_item *)') [-Werror,-Wincompatible-function-pointer-types]
.iop_comitted = xfs_log_item_committed_done,
^~~~~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
--
In file included from fs/xfs/xfs_rmap_item.c:15:
>> fs/xfs/xfs_trans.h:104:65: error: expected ';' after top level declarator
xfs_lsn_t xfs_log_item_committed_done(struct xfs_log_item *item)
^
;
>> fs/xfs/xfs_rmap_item.c:237:3: error: field designator 'iop_comitted' does not refer to any field in type 'const struct xfs_item_ops'; did you mean 'iop_committed'?
.iop_comitted = xfs_log_item_committed_done,
^~~~~~~~~~~~
iop_committed
fs/xfs/xfs_trans.h:73:14: note: 'iop_committed' declared here
xfs_lsn_t (*iop_committed)(struct xfs_log_item *, xfs_lsn_t);
^
>> fs/xfs/xfs_rmap_item.c:237:18: error: incompatible function pointer types initializing 'xfs_lsn_t (*)(struct xfs_log_item *, xfs_lsn_t)' (aka 'long long (*)(struct xfs_log_item *, long long)') with an expression of type 'xfs_lsn_t (struct xfs_log_item *)' (aka 'long long (struct xfs_log_item *)') [-Werror,-Wincompatible-function-pointer-types]
.iop_comitted = xfs_log_item_committed_done,
^~~~~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
vim +104 fs/xfs/xfs_trans.h
96
97 void xfs_log_item_init(struct xfs_mount *mp, struct xfs_log_item *item,
98 int type, const struct xfs_item_ops *ops);
99
100 /*
101 * Generic ->iop_committed callback to indicate that the log item should not be
102 * referenced by the caller once the callback returns.
103 */
> 104 xfs_lsn_t xfs_log_item_committed_done(struct xfs_log_item *item)
105
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38110 bytes --]
prev parent reply other threads:[~2021-05-04 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 4:28 [PATCH] xfs: remove XFS_ITEM_RELEASE_WHEN_COMMITTED Dave Chinner
2021-05-04 7:20 ` Dave Chinner
2021-05-04 9:04 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202105041607.uURlpJ7I-lkp@intel.com \
--to=lkp@intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=david@fromorbit.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox