From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] libxfs: copy crtime correctly now that it's timespec64
Date: Thu, 6 May 2021 07:39:56 +0100 [thread overview]
Message-ID: <20210506063956.GA328487@infradead.org> (raw)
In-Reply-To: <20210505170142.GC8582@magnolia>
On Wed, May 05, 2021 at 10:01:42AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> The incore i_mtime and di_crtime are both timespec64 now, which means
> that tv_sec is a 64-bit value. Don't cast that to int32_t when we're
> creating an inode, because we'll end up truncating the creation time
> incorrectly, should an xfsprogs of this vintage make it to 2039. :P
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
I'm not sure the struct copy comment is all that useful, but otherwise
this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2021-05-06 6:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 17:01 [PATCH] libxfs: copy crtime correctly now that it's timespec64 Darrick J. Wong
2021-05-06 6:39 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506063956.GA328487@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox