From: "Darrick J. Wong" <djwong@kernel.org>
To: Eryu Guan <eguan@linux.alibaba.com>
Cc: Eryu Guan <guan@eryu.me>,
guaneryu@gmail.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org
Subject: Re: [PATCH 2/8] common/xfs: refactor commands to select a particular xfs backing device
Date: Wed, 19 May 2021 13:46:53 -0700 [thread overview]
Message-ID: <20210519204653.GC9648@magnolia> (raw)
In-Reply-To: <20210519030324.GB60846@e18g06458.et15sqa>
On Wed, May 19, 2021 at 11:03:24AM +0800, Eryu Guan wrote:
> On Sun, May 16, 2021 at 01:34:37PM -0700, Darrick J. Wong wrote:
> > On Sun, May 16, 2021 at 11:49:55PM +0800, Eryu Guan wrote:
> > > On Tue, May 11, 2021 at 07:01:51PM -0700, Darrick J. Wong wrote:
> > > > From: Darrick J. Wong <djwong@kernel.org>
> > > >
> > > > Refactor all the places where we try to force new file data allocations
> > > > to a specific xfs backing device so that we don't end up open-coding the
> > > > same xfs_io command lines over and over.
> > > >
> > > > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > > > ---
> > > > common/populate | 2 +-
> > > > common/xfs | 25 +++++++++++++++++++++++++
> > > > tests/generic/223 | 3 ++-
> > > > tests/generic/449 | 2 +-
> > > > tests/xfs/004 | 2 +-
> > >
> > > > tests/xfs/088 | 1 +
> > > > tests/xfs/089 | 1 +
> > > > tests/xfs/091 | 1 +
> > > > tests/xfs/120 | 1 +
> > > > tests/xfs/130 | 1 +
> > >
> > > I think above updates should be in a separate patch.
> >
> > Why?
>
> This patch is refactoring open-coded command into a helper, which should
> not change the logic. But above changes are adding new users of this
> helper and change test behavior. So I think they should be in a separate
> patch for review.
Oh, ok. Will do then.
--D
> Thanks,
> Eryu
next prev parent reply other threads:[~2021-05-19 20:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 2:01 [PATCHSET 0/8] fstests: miscellaneous fixes Darrick J. Wong
2021-05-12 2:01 ` [PATCH 1/8] xfs/122: add entries for structures added to 5.13 Darrick J. Wong
2021-05-12 2:01 ` [PATCH 2/8] common/xfs: refactor commands to select a particular xfs backing device Darrick J. Wong
2021-05-16 15:49 ` Eryu Guan
2021-05-16 20:34 ` Darrick J. Wong
2021-05-19 3:03 ` Eryu Guan
2021-05-19 20:46 ` Darrick J. Wong [this message]
2021-05-12 2:01 ` [PATCH 3/8] xfs: fix old fuzz test invocations of xfs_repair Darrick J. Wong
2021-05-12 2:02 ` [PATCH 4/8] xfs/117: fix fragility in this fuzz test Darrick J. Wong
2021-05-12 2:02 ` [PATCH 5/8] common: always pass -f to $DUMP_COMPRESSOR Darrick J. Wong
2021-05-12 2:02 ` [PATCH 6/8] fsx/fsstress: round blocksize properly Darrick J. Wong
2021-05-12 2:02 ` [PATCH 7/8] fsx: fix backwards parameters in complaint about overly long copy Darrick J. Wong
2021-05-12 2:02 ` [PATCH 8/8] xfs/178: fix mkfs success test Darrick J. Wong
2021-05-16 15:54 ` Eryu Guan
2021-05-19 23:20 ` Darrick J. Wong
2021-05-16 15:58 ` [PATCHSET 0/8] fstests: miscellaneous fixes Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210519204653.GC9648@magnolia \
--to=djwong@kernel.org \
--cc=eguan@linux.alibaba.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox