Re: [PATCH 4/6] xfs: add a free space extent change reservation

kernel test robot
2021-05-27T06:38:36Z

[-- Attachment #1: Type: text/plain, Size: 2403 bytes --]

Hi Dave,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on xfs-linux/for-next]
[also build test WARNING on v5.13-rc3 next-20210526]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Dave-Chinner/xfs-bunmapi-needs-updating-for-deferred-freeing/20210527-125525
base: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next
config: parisc-randconfig-r036-20210527 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/79189c83717c1c3653f6870ab803b4f1eb5d6159
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dave-Chinner/xfs-bunmapi-needs-updating-for-deferred-freeing/20210527-125525
git checkout 79189c83717c1c3653f6870ab803b4f1eb5d6159
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/xfs/libxfs/xfs_trans_resv.c:91:1: warning: no previous prototype for 'xfs_allocfree_extent_res' [-Wmissing-prototypes]
91 | xfs_allocfree_extent_res(
| ^~~~~~~~~~~~~~~~~~~~~~~~

vim +/xfs_allocfree_extent_res +91 fs/xfs/libxfs/xfs_trans_resv.c

81
82 /*
83 * Log reservation required to add or remove a single extent to the free space
84 * btrees. This requires modifying:
85 *
86 * the agf header: 1 sector
87 * the agfl header: 1 sector
88 * the allocation btrees: 2 trees * (max depth - 1) * block size
89 */
90 uint
> 91 xfs_allocfree_extent_res(
92 struct xfs_mount *mp)
93 {
94 return xfs_calc_buf_res(2, mp->m_sb.sb_sectsize) +
95 xfs_calc_buf_res(xfs_allocfree_log_count(mp, 1),
96 XFS_FSB_TO_B(mp, 1));
97 }
98

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29801 bytes --]