From: "Darrick J. Wong" <djwong@kernel.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: sort variable alphabetically to avoid repeated declaration
Date: Fri, 28 May 2021 09:31:13 -0700 [thread overview]
Message-ID: <20210528163113.GP2402049@locust> (raw)
In-Reply-To: <1622181328-9852-1-git-send-email-zhangshaokun@hisilicon.com>
On Fri, May 28, 2021 at 01:55:28PM +0800, Shaokun Zhang wrote:
> Variable 'xfs_agf_buf_ops', 'xfs_agi_buf_ops', 'xfs_dquot_buf_ops' and
> 'xfs_symlink_buf_ops' are declared twice, so sort these variables
> alphabetically and remove the repeated declaration.
>
> Cc: "Darrick J. Wong" <djwong@kernel.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Looks fine to me,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_shared.h | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_shared.h b/fs/xfs/libxfs/xfs_shared.h
> index 782fdd08f759..25c4cab58851 100644
> --- a/fs/xfs/libxfs/xfs_shared.h
> +++ b/fs/xfs/libxfs/xfs_shared.h
> @@ -22,30 +22,26 @@ struct xfs_inode;
> * Buffer verifier operations are widely used, including userspace tools
> */
> extern const struct xfs_buf_ops xfs_agf_buf_ops;
> -extern const struct xfs_buf_ops xfs_agi_buf_ops;
> -extern const struct xfs_buf_ops xfs_agf_buf_ops;
> extern const struct xfs_buf_ops xfs_agfl_buf_ops;
> -extern const struct xfs_buf_ops xfs_bnobt_buf_ops;
> -extern const struct xfs_buf_ops xfs_cntbt_buf_ops;
> -extern const struct xfs_buf_ops xfs_rmapbt_buf_ops;
> -extern const struct xfs_buf_ops xfs_refcountbt_buf_ops;
> +extern const struct xfs_buf_ops xfs_agi_buf_ops;
> extern const struct xfs_buf_ops xfs_attr3_leaf_buf_ops;
> extern const struct xfs_buf_ops xfs_attr3_rmt_buf_ops;
> extern const struct xfs_buf_ops xfs_bmbt_buf_ops;
> +extern const struct xfs_buf_ops xfs_bnobt_buf_ops;
> +extern const struct xfs_buf_ops xfs_cntbt_buf_ops;
> extern const struct xfs_buf_ops xfs_da3_node_buf_ops;
> extern const struct xfs_buf_ops xfs_dquot_buf_ops;
> -extern const struct xfs_buf_ops xfs_symlink_buf_ops;
> -extern const struct xfs_buf_ops xfs_agi_buf_ops;
> -extern const struct xfs_buf_ops xfs_inobt_buf_ops;
> +extern const struct xfs_buf_ops xfs_dquot_buf_ra_ops;
> extern const struct xfs_buf_ops xfs_finobt_buf_ops;
> +extern const struct xfs_buf_ops xfs_inobt_buf_ops;
> extern const struct xfs_buf_ops xfs_inode_buf_ops;
> extern const struct xfs_buf_ops xfs_inode_buf_ra_ops;
> -extern const struct xfs_buf_ops xfs_dquot_buf_ops;
> -extern const struct xfs_buf_ops xfs_dquot_buf_ra_ops;
> +extern const struct xfs_buf_ops xfs_refcountbt_buf_ops;
> +extern const struct xfs_buf_ops xfs_rmapbt_buf_ops;
> +extern const struct xfs_buf_ops xfs_rtbuf_ops;
> extern const struct xfs_buf_ops xfs_sb_buf_ops;
> extern const struct xfs_buf_ops xfs_sb_quiet_buf_ops;
> extern const struct xfs_buf_ops xfs_symlink_buf_ops;
> -extern const struct xfs_buf_ops xfs_rtbuf_ops;
>
> /* log size calculation functions */
> int xfs_log_calc_unit_res(struct xfs_mount *mp, int unit_bytes);
> --
> 2.7.4
>
next prev parent reply other threads:[~2021-05-28 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 5:55 [PATCH] xfs: sort variable alphabetically to avoid repeated declaration Shaokun Zhang
2021-05-28 16:31 ` Darrick J. Wong [this message]
2021-05-31 12:27 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528163113.GP2402049@locust \
--to=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox