* [PATCH] xfs: sort variable alphabetically to avoid repeated declaration
@ 2021-05-28 5:55 Shaokun Zhang
2021-05-28 16:31 ` Darrick J. Wong
2021-05-31 12:27 ` Carlos Maiolino
0 siblings, 2 replies; 3+ messages in thread
From: Shaokun Zhang @ 2021-05-28 5:55 UTC (permalink / raw)
To: linux-xfs; +Cc: Shaokun Zhang, Darrick J. Wong
Variable 'xfs_agf_buf_ops', 'xfs_agi_buf_ops', 'xfs_dquot_buf_ops' and
'xfs_symlink_buf_ops' are declared twice, so sort these variables
alphabetically and remove the repeated declaration.
Cc: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
fs/xfs/libxfs/xfs_shared.h | 20 ++++++++------------
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_shared.h b/fs/xfs/libxfs/xfs_shared.h
index 782fdd08f759..25c4cab58851 100644
--- a/fs/xfs/libxfs/xfs_shared.h
+++ b/fs/xfs/libxfs/xfs_shared.h
@@ -22,30 +22,26 @@ struct xfs_inode;
* Buffer verifier operations are widely used, including userspace tools
*/
extern const struct xfs_buf_ops xfs_agf_buf_ops;
-extern const struct xfs_buf_ops xfs_agi_buf_ops;
-extern const struct xfs_buf_ops xfs_agf_buf_ops;
extern const struct xfs_buf_ops xfs_agfl_buf_ops;
-extern const struct xfs_buf_ops xfs_bnobt_buf_ops;
-extern const struct xfs_buf_ops xfs_cntbt_buf_ops;
-extern const struct xfs_buf_ops xfs_rmapbt_buf_ops;
-extern const struct xfs_buf_ops xfs_refcountbt_buf_ops;
+extern const struct xfs_buf_ops xfs_agi_buf_ops;
extern const struct xfs_buf_ops xfs_attr3_leaf_buf_ops;
extern const struct xfs_buf_ops xfs_attr3_rmt_buf_ops;
extern const struct xfs_buf_ops xfs_bmbt_buf_ops;
+extern const struct xfs_buf_ops xfs_bnobt_buf_ops;
+extern const struct xfs_buf_ops xfs_cntbt_buf_ops;
extern const struct xfs_buf_ops xfs_da3_node_buf_ops;
extern const struct xfs_buf_ops xfs_dquot_buf_ops;
-extern const struct xfs_buf_ops xfs_symlink_buf_ops;
-extern const struct xfs_buf_ops xfs_agi_buf_ops;
-extern const struct xfs_buf_ops xfs_inobt_buf_ops;
+extern const struct xfs_buf_ops xfs_dquot_buf_ra_ops;
extern const struct xfs_buf_ops xfs_finobt_buf_ops;
+extern const struct xfs_buf_ops xfs_inobt_buf_ops;
extern const struct xfs_buf_ops xfs_inode_buf_ops;
extern const struct xfs_buf_ops xfs_inode_buf_ra_ops;
-extern const struct xfs_buf_ops xfs_dquot_buf_ops;
-extern const struct xfs_buf_ops xfs_dquot_buf_ra_ops;
+extern const struct xfs_buf_ops xfs_refcountbt_buf_ops;
+extern const struct xfs_buf_ops xfs_rmapbt_buf_ops;
+extern const struct xfs_buf_ops xfs_rtbuf_ops;
extern const struct xfs_buf_ops xfs_sb_buf_ops;
extern const struct xfs_buf_ops xfs_sb_quiet_buf_ops;
extern const struct xfs_buf_ops xfs_symlink_buf_ops;
-extern const struct xfs_buf_ops xfs_rtbuf_ops;
/* log size calculation functions */
int xfs_log_calc_unit_res(struct xfs_mount *mp, int unit_bytes);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: sort variable alphabetically to avoid repeated declaration
2021-05-28 5:55 [PATCH] xfs: sort variable alphabetically to avoid repeated declaration Shaokun Zhang
@ 2021-05-28 16:31 ` Darrick J. Wong
2021-05-31 12:27 ` Carlos Maiolino
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2021-05-28 16:31 UTC (permalink / raw)
To: Shaokun Zhang; +Cc: linux-xfs
On Fri, May 28, 2021 at 01:55:28PM +0800, Shaokun Zhang wrote:
> Variable 'xfs_agf_buf_ops', 'xfs_agi_buf_ops', 'xfs_dquot_buf_ops' and
> 'xfs_symlink_buf_ops' are declared twice, so sort these variables
> alphabetically and remove the repeated declaration.
>
> Cc: "Darrick J. Wong" <djwong@kernel.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Looks fine to me,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_shared.h | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_shared.h b/fs/xfs/libxfs/xfs_shared.h
> index 782fdd08f759..25c4cab58851 100644
> --- a/fs/xfs/libxfs/xfs_shared.h
> +++ b/fs/xfs/libxfs/xfs_shared.h
> @@ -22,30 +22,26 @@ struct xfs_inode;
> * Buffer verifier operations are widely used, including userspace tools
> */
> extern const struct xfs_buf_ops xfs_agf_buf_ops;
> -extern const struct xfs_buf_ops xfs_agi_buf_ops;
> -extern const struct xfs_buf_ops xfs_agf_buf_ops;
> extern const struct xfs_buf_ops xfs_agfl_buf_ops;
> -extern const struct xfs_buf_ops xfs_bnobt_buf_ops;
> -extern const struct xfs_buf_ops xfs_cntbt_buf_ops;
> -extern const struct xfs_buf_ops xfs_rmapbt_buf_ops;
> -extern const struct xfs_buf_ops xfs_refcountbt_buf_ops;
> +extern const struct xfs_buf_ops xfs_agi_buf_ops;
> extern const struct xfs_buf_ops xfs_attr3_leaf_buf_ops;
> extern const struct xfs_buf_ops xfs_attr3_rmt_buf_ops;
> extern const struct xfs_buf_ops xfs_bmbt_buf_ops;
> +extern const struct xfs_buf_ops xfs_bnobt_buf_ops;
> +extern const struct xfs_buf_ops xfs_cntbt_buf_ops;
> extern const struct xfs_buf_ops xfs_da3_node_buf_ops;
> extern const struct xfs_buf_ops xfs_dquot_buf_ops;
> -extern const struct xfs_buf_ops xfs_symlink_buf_ops;
> -extern const struct xfs_buf_ops xfs_agi_buf_ops;
> -extern const struct xfs_buf_ops xfs_inobt_buf_ops;
> +extern const struct xfs_buf_ops xfs_dquot_buf_ra_ops;
> extern const struct xfs_buf_ops xfs_finobt_buf_ops;
> +extern const struct xfs_buf_ops xfs_inobt_buf_ops;
> extern const struct xfs_buf_ops xfs_inode_buf_ops;
> extern const struct xfs_buf_ops xfs_inode_buf_ra_ops;
> -extern const struct xfs_buf_ops xfs_dquot_buf_ops;
> -extern const struct xfs_buf_ops xfs_dquot_buf_ra_ops;
> +extern const struct xfs_buf_ops xfs_refcountbt_buf_ops;
> +extern const struct xfs_buf_ops xfs_rmapbt_buf_ops;
> +extern const struct xfs_buf_ops xfs_rtbuf_ops;
> extern const struct xfs_buf_ops xfs_sb_buf_ops;
> extern const struct xfs_buf_ops xfs_sb_quiet_buf_ops;
> extern const struct xfs_buf_ops xfs_symlink_buf_ops;
> -extern const struct xfs_buf_ops xfs_rtbuf_ops;
>
> /* log size calculation functions */
> int xfs_log_calc_unit_res(struct xfs_mount *mp, int unit_bytes);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: sort variable alphabetically to avoid repeated declaration
2021-05-28 5:55 [PATCH] xfs: sort variable alphabetically to avoid repeated declaration Shaokun Zhang
2021-05-28 16:31 ` Darrick J. Wong
@ 2021-05-31 12:27 ` Carlos Maiolino
1 sibling, 0 replies; 3+ messages in thread
From: Carlos Maiolino @ 2021-05-31 12:27 UTC (permalink / raw)
To: Shaokun Zhang; +Cc: linux-xfs, Darrick J. Wong
On Fri, May 28, 2021 at 01:55:28PM +0800, Shaokun Zhang wrote:
> Variable 'xfs_agf_buf_ops', 'xfs_agi_buf_ops', 'xfs_dquot_buf_ops' and
> 'xfs_symlink_buf_ops' are declared twice, so sort these variables
> alphabetically and remove the repeated declaration.
>
> Cc: "Darrick J. Wong" <djwong@kernel.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Looks good.
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> fs/xfs/libxfs/xfs_shared.h | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_shared.h b/fs/xfs/libxfs/xfs_shared.h
> index 782fdd08f759..25c4cab58851 100644
> --- a/fs/xfs/libxfs/xfs_shared.h
> +++ b/fs/xfs/libxfs/xfs_shared.h
> @@ -22,30 +22,26 @@ struct xfs_inode;
> * Buffer verifier operations are widely used, including userspace tools
> */
> extern const struct xfs_buf_ops xfs_agf_buf_ops;
> -extern const struct xfs_buf_ops xfs_agi_buf_ops;
> -extern const struct xfs_buf_ops xfs_agf_buf_ops;
> extern const struct xfs_buf_ops xfs_agfl_buf_ops;
> -extern const struct xfs_buf_ops xfs_bnobt_buf_ops;
> -extern const struct xfs_buf_ops xfs_cntbt_buf_ops;
> -extern const struct xfs_buf_ops xfs_rmapbt_buf_ops;
> -extern const struct xfs_buf_ops xfs_refcountbt_buf_ops;
> +extern const struct xfs_buf_ops xfs_agi_buf_ops;
> extern const struct xfs_buf_ops xfs_attr3_leaf_buf_ops;
> extern const struct xfs_buf_ops xfs_attr3_rmt_buf_ops;
> extern const struct xfs_buf_ops xfs_bmbt_buf_ops;
> +extern const struct xfs_buf_ops xfs_bnobt_buf_ops;
> +extern const struct xfs_buf_ops xfs_cntbt_buf_ops;
> extern const struct xfs_buf_ops xfs_da3_node_buf_ops;
> extern const struct xfs_buf_ops xfs_dquot_buf_ops;
> -extern const struct xfs_buf_ops xfs_symlink_buf_ops;
> -extern const struct xfs_buf_ops xfs_agi_buf_ops;
> -extern const struct xfs_buf_ops xfs_inobt_buf_ops;
> +extern const struct xfs_buf_ops xfs_dquot_buf_ra_ops;
> extern const struct xfs_buf_ops xfs_finobt_buf_ops;
> +extern const struct xfs_buf_ops xfs_inobt_buf_ops;
> extern const struct xfs_buf_ops xfs_inode_buf_ops;
> extern const struct xfs_buf_ops xfs_inode_buf_ra_ops;
> -extern const struct xfs_buf_ops xfs_dquot_buf_ops;
> -extern const struct xfs_buf_ops xfs_dquot_buf_ra_ops;
> +extern const struct xfs_buf_ops xfs_refcountbt_buf_ops;
> +extern const struct xfs_buf_ops xfs_rmapbt_buf_ops;
> +extern const struct xfs_buf_ops xfs_rtbuf_ops;
> extern const struct xfs_buf_ops xfs_sb_buf_ops;
> extern const struct xfs_buf_ops xfs_sb_quiet_buf_ops;
> extern const struct xfs_buf_ops xfs_symlink_buf_ops;
> -extern const struct xfs_buf_ops xfs_rtbuf_ops;
>
> /* log size calculation functions */
> int xfs_log_calc_unit_res(struct xfs_mount *mp, int unit_bytes);
> --
> 2.7.4
>
--
Carlos
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-31 12:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-28 5:55 [PATCH] xfs: sort variable alphabetically to avoid repeated declaration Shaokun Zhang
2021-05-28 16:31 ` Darrick J. Wong
2021-05-31 12:27 ` Carlos Maiolino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox