Re: [PATCH 14/14] xfs: refactor per-AG inode tagging functions

Dave Chinner
2021-06-02T02:22:57Z

On Tue, Jun 01, 2021 at 05:53:49PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> In preparation for adding another incore inode tree tag, refactor the
> code that sets and clears tags from the per-AG inode tree and the tree
> of per-AG structures, and remove the open-coded versions used by the
> blockgc code.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/xfs_icache.c | 158 +++++++++++++++++++++++++--------------------------
> fs/xfs/xfs_icache.h | 2 -
> fs/xfs/xfs_super.c | 2 -
> fs/xfs/xfs_trace.h | 6 +-
> 4 files changed, 80 insertions(+), 88 deletions(-)

There's a few little logic changes in amongst the changes,
largely around using tree tag status rather than reclaimable inode
counts in the reclaim tagging logic, but the conversion looks
correct.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com