Re: [PATCH 12/14] xfs: pass struct xfs_eofblocks to the inode scan callback

Darrick J. Wong
2021-06-02T06:15:38Z

On Wed, Jun 02, 2021 at 12:04:16PM +1000, Dave Chinner wrote:
> On Tue, Jun 01, 2021 at 05:53:38PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Pass a pointer to the actual eofb structure around the inode scanner
> > functions instead of a void pointer, now that none of the functions is
> > used as a callback.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > ---
> > fs/xfs/xfs_icache.c | 30 +++++++++++++-----------------
> > 1 file changed, 13 insertions(+), 17 deletions(-)
>
> Looks ok.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>
> As mentioned in #xfs, I think there's followup work here to rename
> struct xfs_eofblocks to struct xfs_icwalk now that it really has
> nothing specific to do with eofblock scanning anymore.

Ok, I'll tack a rename patch on the end.

--D

>
> -Dave.
> --
> Dave Chinner
> david@fromorbit.com