Re: [PATCH 13/14] xfs: merge xfs_reclaim_inodes_ag into xfs_inode_walk_ag

Dave Chinner
2021-06-02T02:11:00Z

On Tue, Jun 01, 2021 at 05:53:44PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Merge these two inode walk loops together, since they're pretty similar
> now.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/xfs_icache.c | 151 +++++++++++++--------------------------------------
> fs/xfs/xfs_icache.h | 7 ++
> 2 files changed, 45 insertions(+), 113 deletions(-)

At last! Nice work.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

> @@ -1678,6 +1577,14 @@ xfs_blockgc_free_quota(
>
> /* XFS Incore Inode Walking Code */

FWIW, if we are using "icwalk" as the namespace, I keep saying
"inode cache walk" in my head. Perhaps update this comment somewhere
to match the namespace?

-Dave.
--
Dave Chinner
david@fromorbit.com