From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 13/14] xfs: merge xfs_reclaim_inodes_ag into xfs_inode_walk_ag
Date: Tue, 1 Jun 2021 23:16:48 -0700 [thread overview]
Message-ID: <20210602061648.GI26380@locust> (raw)
In-Reply-To: <20210602021055.GS664593@dread.disaster.area>
On Wed, Jun 02, 2021 at 12:10:55PM +1000, Dave Chinner wrote:
> On Tue, Jun 01, 2021 at 05:53:44PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Merge these two inode walk loops together, since they're pretty similar
> > now.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> > fs/xfs/xfs_icache.c | 151 +++++++++++++--------------------------------------
> > fs/xfs/xfs_icache.h | 7 ++
> > 2 files changed, 45 insertions(+), 113 deletions(-)
>
> At last! Nice work.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>
> > @@ -1678,6 +1577,14 @@ xfs_blockgc_free_quota(
> >
> > /* XFS Incore Inode Walking Code */
>
> FWIW, if we are using "icwalk" as the namespace, I keep saying
> "inode cache walk" in my head. Perhaps update this comment somewhere
> to match the namespace?
Done.
--D
>
> -Dave.
> --
> Dave Chinner
> david@fromorbit.com
next prev parent reply other threads:[~2021-06-02 6:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 0:52 [PATCHSET v5 00/14] xfs: clean up incore inode walk functions Darrick J. Wong
2021-06-02 0:52 ` [PATCH 01/14] xfs: move the quotaoff dqrele inode walk into xfs_icache.c Darrick J. Wong
2021-06-02 1:23 ` Dave Chinner
2021-06-02 0:52 ` [PATCH 02/14] xfs: detach inode dquots at the end of inactivation Darrick J. Wong
2021-06-02 0:52 ` [PATCH 03/14] xfs: move the inode walk functions further down Darrick J. Wong
2021-06-02 1:26 ` Dave Chinner
2021-06-02 0:52 ` [PATCH 04/14] xfs: pass the goal of the incore inode walk to xfs_inode_walk() Darrick J. Wong
2021-06-02 1:42 ` Dave Chinner
2021-06-02 0:53 ` [PATCH 05/14] xfs: separate the dqrele_all inode grab logic from xfs_inode_walk_ag_grab Darrick J. Wong
2021-06-02 1:51 ` Dave Chinner
2021-06-02 3:28 ` Darrick J. Wong
2021-06-02 0:53 ` [PATCH 06/14] xfs: move xfs_inew_wait call into xfs_dqrele_inode Darrick J. Wong
2021-06-02 1:52 ` Dave Chinner
2021-06-02 0:53 ` [PATCH 07/14] xfs: remove iter_flags parameter from xfs_inode_walk_* Darrick J. Wong
2021-06-02 1:53 ` Dave Chinner
2021-06-02 0:53 ` [PATCH 08/14] xfs: remove indirect calls from xfs_inode_walk{,_ag} Darrick J. Wong
2021-06-02 2:00 ` Dave Chinner
2021-06-02 0:53 ` [PATCH 09/14] xfs: clean up the blockgc grab and scan calls a little Darrick J. Wong
2021-06-02 0:53 ` [PATCH 10/14] xfs: clean up xfs_dqrele_inode calling conventions Darrick J. Wong
2021-06-02 0:53 ` [PATCH 11/14] xfs: fix radix tree tag signs Darrick J. Wong
2021-06-02 2:02 ` Dave Chinner
2021-06-02 0:53 ` [PATCH 12/14] xfs: pass struct xfs_eofblocks to the inode scan callback Darrick J. Wong
2021-06-02 2:04 ` Dave Chinner
2021-06-02 6:15 ` Darrick J. Wong
2021-06-02 0:53 ` [PATCH 13/14] xfs: merge xfs_reclaim_inodes_ag into xfs_inode_walk_ag Darrick J. Wong
2021-06-02 2:10 ` Dave Chinner
2021-06-02 6:16 ` Darrick J. Wong [this message]
2021-06-02 0:53 ` [PATCH 14/14] xfs: refactor per-AG inode tagging functions Darrick J. Wong
2021-06-02 2:22 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602061648.GI26380@locust \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).