Re: [PATCH 04/10] fstests: move test group info to test files

Eric Biggers
2021-06-03T04:58:06Z

On Tue, May 25, 2021 at 06:47:04PM -0700, Darrick J. Wong wrote:
> diff --git a/tests/btrfs/001 b/tests/btrfs/001
> index fb051e8a..2248b6f6 100755
> --- a/tests/btrfs/001
> +++ b/tests/btrfs/001
> @@ -6,13 +6,9 @@
> #
> # Test btrfs's subvolume and snapshot support
> #
> -seq=`basename $0`
> -seqres=$RESULT_DIR/$seq
> -echo "QA output created by $seq"
> +. ./common/test_names
> +_set_seq_and_groups auto quick subvol snapshot

The naming is a little weird here. This feels more like a common preamble,
especially given that it also sets $here, $tmp, and $status -- not just the test
groups. Maybe it should look like:

. ./common/preamble
_begin_fstest quick subvol snapshot