Re: [PATCHSET RFC 00/10] fstests: move test group lists into test files

Amir Goldstein
2021-06-03T06:32:28Z

On Wed, May 26, 2021 at 5:50 AM Darrick J. Wong <djwong@kernel.org> wrote:
>
> Hi all,
>
> Test group files (e.g. tests/generic/group) are a pain to keep up.
> Every week I rebase on Eryu's latest upstream, and every week I have to
> slog through dozens of trivial merge conflicts because of the
> groupfiles. Moving tests is annoying because we have to maintain all
> this code to move the group associations from one /group file to
> another.
>
> It doesn't need to be this way -- we could move each test's group
> information into the test itself, and automatically generate the group
> files as part of the make process. This series does exactly that.
>

This looks very nice :)

I do have one concern.
If the auto-generated group files keep the same path as the existing
source controlled group files, checkout of pre/post this change is
going to be challenging for developers running make in the source
directory.

Also .gitignore entries are needed for the auto-generated group files.

I wonder if it wouldn't be easier for everyone if the auto-generated
groups had a different name.

Thanks,
Amir.