[PATCH 5/9] xfs: force inode garbage collection before fallocate when space is low

Darrick J. Wong
2021-06-07T22:25:22Z

From: Darrick J. Wong <djwong@kernel.org>

Generally speaking, when a user calls fallocate, they're looking to
preallocate space in a file in the largest contiguous chunks possible.
If free space is low, it's possible that the free space will look
unnecessarily fragmented because there are unlinked inodes that are
holding on to space that we could allocate. When this happens,
fallocate makes suboptimal allocation decisions for the sake of deleted
files, which doesn't make much sense, so scan the filesystem for dead
items to delete to try to avoid this.

Note that there are a handful of fstests that fill a filesystem, delete
just enough files to allow a single large allocation, and check that
fallocate actually gets the allocation. These tests regress because the
test runs fallocate before the inode gc has a chance to run, so add this
behavior to maintain as much of the old behavior as possible.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
fs/xfs/xfs_bmap_util.c | 43 +++++++++++++++++++++++++++++++++++++++++++
fs/xfs/xfs_icache.c | 8 ++++++++
fs/xfs/xfs_icache.h | 1 +
3 files changed, 52 insertions(+)

diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
index 997eb5c6e9b4..a1be77fe89d6 100644
--- a/fs/xfs/xfs_bmap_util.c
+++ b/fs/xfs/xfs_bmap_util.c
@@ -28,6 +28,8 @@
#include "xfs_icache.h"
#include "xfs_iomap.h"
#include "xfs_reflink.h"
+#include "xfs_sb.h"
+#include "xfs_ag.h"

/* Kernel only BMAP related definitions and functions */

@@ -767,6 +769,43 @@ xfs_free_eofblocks(
return error;
}

+/*
+ * If the target device (or some part of it) is full enough that it won't to be
+ * able to satisfy the entire request, try to free inactive files to free up
+ * space. While it's perfectly fine to fill a preallocation request with a
+ * bunch of short extents, we prefer to slow down preallocation requests to
+ * combat long term fragmentation in new file data.
+ */
+static int
+xfs_alloc_consolidate_freespace(
+ struct xfs_inode *ip,
+ xfs_filblks_t wanted)
+{
+ struct xfs_mount *mp = ip->i_mount;
+ struct xfs_perag *pag;
+ struct xfs_sb *sbp = &mp->m_sb;
+ xfs_agnumber_t agno;
+
+ if (!xfs_has_inodegc_work(mp))
+ return 0;
+
+ if (XFS_IS_REALTIME_INODE(ip)) {
+ if (sbp->sb_frextents * sbp->sb_rextsize >= wanted)
+ return 0;
+ goto free_space;
+ }
+
+ for_each_perag(mp, agno, pag) {
+ if (pag->pagf_freeblks >= wanted) {
+ xfs_perag_put(pag);
+ return 0;
+ }
+ }
+
+free_space:
+ return xfs_inodegc_free_space(mp, NULL);
+}
+
int
xfs_alloc_file_space(
struct xfs_inode *ip,
@@ -851,6 +890,10 @@ xfs_alloc_file_space(
rblocks = 0;
}

+ error = xfs_alloc_consolidate_freespace(ip, allocatesize_fsb);
+ if (error)
+ break;
+
/*
* Allocate and setup the transaction.
*/
diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
index a7ca6b988e29..8016e90b7b6d 100644
--- a/fs/xfs/xfs_icache.c
+++ b/fs/xfs/xfs_icache.c
@@ -1965,6 +1965,14 @@ xfs_inodegc_start(
xfs_inodegc_queue(mp);
}

+/* Are there files waiting for inactivation? */
+bool
+xfs_has_inodegc_work(
+ struct xfs_mount *mp)
+{
+ return radix_tree_tagged(&mp->m_perag_tree, XFS_ICI_INODEGC_TAG);
+}
+
/* XFS Inode Cache Walking Code */

/*
diff --git a/fs/xfs/xfs_icache.h b/fs/xfs/xfs_icache.h
index d03d46f83316..1f693e7fe6c8 100644
--- a/fs/xfs/xfs_icache.h
+++ b/fs/xfs/xfs_icache.h
@@ -85,6 +85,7 @@ void xfs_inodegc_flush(struct xfs_mount *mp);
void xfs_inodegc_stop(struct xfs_mount *mp);
void xfs_inodegc_start(struct xfs_mount *mp);
int xfs_inodegc_free_space(struct xfs_mount *mp, struct xfs_icwalk *icw);
+bool xfs_has_inodegc_work(struct xfs_mount *mp);

/*
* Process all pending inode inactivations immediately (sort of) so that a