From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA8BC48BD1 for ; Thu, 10 Jun 2021 22:50:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DD7B613F5 for ; Thu, 10 Jun 2021 22:50:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230284AbhFJWwY (ORCPT ); Thu, 10 Jun 2021 18:52:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:41138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230001AbhFJWwX (ORCPT ); Thu, 10 Jun 2021 18:52:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EE81A613E7; Thu, 10 Jun 2021 22:50:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623365427; bh=VPZqJQrM3RlOzyEINLx/dD45UqFCvIgG2sHH9I+7DRA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EKzIXqBEhgWG41vWCLck3PvwdryfUhHE/aFO/CCalFt4kinzivK4L1SOk83+nB6yF A5EE2/7qUIMJOmM5sxjJk3ur3CHi+mnJJ/HnAOBn66UDS0Dp8s5HIAc0qdsB7Pt6ny NUyZJx9x+7fpRttrD/eS+bd29NEsRPr2FhF9aoUc2SDA2Y/cHA7hUpBeQPlT4BPZED ssTeiRqdEriH35zNyLKAiRwOa4G+Y84GFZ76ujVsAr7naJJQqIidEsMhpzdltdqeWN 8+9MIP2pyAn6FJBXzvHdsLQsnzwErWYJysxaYisZbLhUrIaOmEmTwuKUnOdwQ61Bck Or1L5fcPHNIFA== Date: Thu, 10 Jun 2021 15:50:26 -0700 From: "Darrick J. Wong" To: Dave Chinner Cc: Geert Uytterhoeven , Dave Chinner , Chandan Babu R , Allison Henderson , Christoph Hellwig , linux-xfs@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, noreply@ellerman.id.au Subject: Re: [PATCH] xfs: Fix 64-bit division on 32-bit in xlog_state_switch_iclogs() Message-ID: <20210610225026.GD2945738@locust> References: <20210610110001.2805317-1-geert@linux-m68k.org> <20210610220155.GQ664593@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210610220155.GQ664593@dread.disaster.area> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, Jun 11, 2021 at 08:01:55AM +1000, Dave Chinner wrote: > On Thu, Jun 10, 2021 at 01:00:01PM +0200, Geert Uytterhoeven wrote: > > On 32-bit (e.g. m68k): > > > > ERROR: modpost: "__udivdi3" [fs/xfs/xfs.ko] undefined! > > > > Fix this by using a uint32_t intermediate, like before. > > > > Reported-by: noreply@ellerman.id.au > > Fixes: 7660a5b48fbef958 ("xfs: log stripe roundoff is a property of the log") > > Signed-off-by: Geert Uytterhoeven > > --- > > Compile-tested only. > > --- > > fs/xfs/xfs_log.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > 64 bit division on 32 bit platforms is still a problem in this day > and age? > > Reviewed-by: Dave Chinner > > Maybe we should just put "requires 64 bit kernel" on XFS these days... But then how will I recover my 100TB XFS using my TV? It only has so much framebuffer that I can abuse for swap memory... >:O Reviewed-by: Darrick J. Wong --D > > -Dave. > -- > Dave Chinner > david@fromorbit.com