From: "Darrick J. Wong" <djwong@kernel.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: remove redundant initialization of variable error
Date: Fri, 11 Jun 2021 17:53:18 -0700 [thread overview]
Message-ID: <20210612005318.GJ2945738@locust> (raw)
In-Reply-To: <1622883170-33317-1-git-send-email-zhangshaokun@hisilicon.com>
On Sat, Jun 05, 2021 at 04:52:50PM +0800, Shaokun Zhang wrote:
> 'error' will be initialized, so clean up the redundant initialization.
>
> Cc: "Darrick J. Wong" <djwong@kernel.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Looks ok,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_buf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index 592800c8852f..59991c8c7127 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -707,7 +707,7 @@ xfs_buf_get_map(
> {
> struct xfs_buf *bp;
> struct xfs_buf *new_bp;
> - int error = 0;
> + int error;
>
> *bpp = NULL;
> error = xfs_buf_find(target, map, nmaps, flags, NULL, &bp);
> --
> 2.7.4
>
prev parent reply other threads:[~2021-06-12 0:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 8:52 [PATCH] xfs: remove redundant initialization of variable error Shaokun Zhang
2021-06-07 13:13 ` Carlos Maiolino
2021-06-08 1:50 ` Shaokun Zhang
2021-06-12 0:53 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210612005318.GJ2945738@locust \
--to=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox