Re: [PATCH 07/13] fstests: automatically generate group files

Darrick J. Wong
2021-06-17T00:13:21Z

On Wed, Jun 16, 2021 at 08:32:28AM +0100, Christoph Hellwig wrote:
> On Mon, Jun 14, 2021 at 01:59:37PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Now that we've moved the group membership details into the test case
> > files themselves, automatically generate the group files during build.
> > The autogenerated files are named "group.list" instead of "group" to
> > avoid conflicts between generated and (stale) SCM files as everyone
> > rebases.
>
> Hmm, so we now need to run make to regenerate the group information?
> That is for sure going to create various issues with people forgetting
> to regenerate it. What about regenerating it everytime a group based
> run is executed?

<shrug> What's wrong with requiring everyone to run 'make' when they
change something in fstests? I suspect most people already do that as
muscle memory for most every other code project on the planet, or as
part of `make install' prior to starting it fstests.

--D