public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Allison Henderson <allison.henderson@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: New Defects reported by Coverity Scan for linux-next weekly scan
Date: Wed, 16 Jun 2021 17:22:04 -0700	[thread overview]
Message-ID: <20210617002204.GB158232@locust> (raw)
In-Reply-To: <60c8c255db7df_c93642aabada739a0965bf@prd-scan-dashboard-0.mail>

Hey Allison,

Would you mind taking a look at this static checker report from the
build robot and fixing whatever it's complaining about, please? :)

--D

> ** CID 1505244:  Uninitialized variables  (UNINIT)
> /fs/xfs/libxfs/xfs_attr.c: 1481 in xfs_attr_remove_iter()
> 
> 
> ________________________________________________________________________________________________________
> *** CID 1505244:  Uninitialized variables  (UNINIT)
> /fs/xfs/libxfs/xfs_attr.c: 1481 in xfs_attr_remove_iter()
> 1475     		 * If the result is small enough, push it all into the inode.
> 1476     		 * This is our final state so it's safe to return a dirty
> 1477     		 * transaction.
> 1478     		 */
> 1479     		if (xfs_attr_is_leaf(dp))
> 1480     			error = xfs_attr_node_shrink(args, state);
> >>>     CID 1505244:  Uninitialized variables  (UNINIT)
> >>>     Using uninitialized value "error".
> 1481     		ASSERT(error != -EAGAIN);
> 1482     		break;
> 1483     	default:
> 1484     		ASSERT(0);
> 1485     		error = -EINVAL;
> 1486     		goto out;
> 

           reply	other threads:[~2021-06-17  0:22 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <60c8c255db7df_c93642aabada739a0965bf@prd-scan-dashboard-0.mail>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210617002204.GB158232@locust \
    --to=djwong@kernel.org \
    --cc=allison.henderson@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox