From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: print name of function causing fs shutdown instead of hex pointer
Date: Thu, 17 Jun 2021 09:10:41 -0700 [thread overview]
Message-ID: <20210617161041.GM158209@locust> (raw)
In-Reply-To: <YMsDmxk6nKehJP0q@infradead.org>
On Thu, Jun 17, 2021 at 09:11:07AM +0100, Christoph Hellwig wrote:
> On Wed, Jun 16, 2021 at 04:55:36PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > In xfs_do_force_shutdown, print the symbolic name of the function that
> > called us to shut down the filesystem instead of a raw hex pointer.
> > This makes debugging a lot easier:
> >
> > XFS (sda): xfs_do_force_shutdown(0x2) called from line 2440 of file
> > fs/xfs/xfs_log.c. Return address = ffffffffa038bc38
> >
> > becomes:
> >
> > XFS (sda): xfs_do_force_shutdown(0x2) called from line 2440 of file
> > fs/xfs/xfs_log.c. Return address = xfs_trans_mod_sb+0x25
>
> Symbolic names looks very useful here. But can we take a step back
> to make this whole printk much more useful, something like:
>
> XFS (sda): Forced shutdown (log I/O error) at fs/xfs/xfs_trans.c:385 (xfs_trans_mod_sb+0x25).
>
> That is print the reason as a string, and mke the whole thing less
> verbose and more readable.
Um, we /do/ log the error already; a full shutdown report looks like:
XFS (sda): xfs_do_force_shutdown(0x2) called from line 2440 of file
fs/xfs/xfs_log.c. Return address = xfs_trans_mod_sb+0x25
XFS (sda): Corruption of in-memory data detected. Shutting down
filesystem
Or are you saying that we should combine them into a single message?
XFS (sda): Corruption of in-memory data detected at xlog_write+0x10
(fs/xfs/xfs_log.c:2440). Shutting down filesystem.
XFS (sda): Log I/O error detected at xlog_write+0x10
(fs/xfs/xfs_log.c:2440). Shutting down filesystem.
XFS (sda): I/O error detected at xlog_write+0x10
(fs/xfs/xfs_log.c:2440). Shutting down filesystem.
etc?
--D
next prev parent reply other threads:[~2021-06-17 16:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 23:55 [PATCHSET 0/2] xfs: various small fixes Darrick J. Wong
2021-06-16 23:55 ` [PATCH 1/2] xfs: fix type mismatches in the inode reclaim functions Darrick J. Wong
2021-06-17 7:58 ` Christoph Hellwig
2021-06-17 15:14 ` Chandan Babu R
2021-06-18 14:33 ` Brian Foster
2021-06-18 14:59 ` Darrick J. Wong
2021-06-16 23:55 ` [PATCH 2/2] xfs: print name of function causing fs shutdown instead of hex pointer Darrick J. Wong
2021-06-17 8:11 ` Christoph Hellwig
2021-06-17 16:10 ` Darrick J. Wong [this message]
2021-06-18 13:58 ` Christoph Hellwig
2021-06-18 16:05 ` Darrick J. Wong
2021-06-18 14:34 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617161041.GM158209@locust \
--to=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox