Re: [PATCH 0/8 V2] xfs: log fixes for for-next

Christoph Hellwig
2021-06-18T13:55:34Z

On Fri, Jun 18, 2021 at 09:08:15AM -0400, Brian Foster wrote:
> Also FYI, earlier iterations of generic/475 triggered a couple instances
> of the following assert failure before things broke down more severely:
>
> XFS: Assertion failed: *log_offset + *len <= iclog->ic_size || iclog->ic_state == XLOG_STATE_WANT_SYNC, file: fs/xfs/xfs_log.c, line: 2115

As you mentioned the placement of this exact assert in my cleanups
series: after looking at a right place to move it, I'm really not sure
this assert makes much sense in this form.

xlog_write_single is always entered first by xlog_write, so we also
get here for something that later gets handled by xlog_write_partial.
Which means it could be way bigger than the current iclog, and I see no
reason why that iclog would have to be XLOG_STATE_WANT_SYNC.