Re: [PATCH 5/8] xfs: factor out log write ordering from xlog_cil_push_work()

Christoph Hellwig
2021-06-18T14:28:12Z

On Thu, Jun 17, 2021 at 12:59:04PM -0700, Darrick J. Wong wrote:
> On Thu, Jun 17, 2021 at 06:26:14PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > So we can use it for start record ordering as well as commit record
> > ordering in future.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
>
> This tricked me for a second until I realized that xlog_cil_order_write
> is the chunk of code just prior to the xlog_cil_write_commit_record
> call.

Yeah, moving the caller at the same time as the factoring is a trick
test for every reader. I think this needs to be documented in the
commit log. Or even better moved to a separate log, but it seems you
get shot for that kind of suggestion on the xfs list these days..