From: "Darrick J. Wong" <djwong@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Eryu Guan <guaneryu@gmail.com>,
Chandan Babu R <chandanrlinux@gmail.com>,
Allison Henderson <allison.henderson@oracle.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
fstests <fstests@vger.kernel.org>, Eryu Guan <guan@eryu.me>,
ebiggers@kernel.org
Subject: Re: [PATCH 07/13] fstests: automatically generate group files
Date: Fri, 18 Jun 2021 08:56:30 -0700 [thread overview]
Message-ID: <20210618155630.GE158209@locust> (raw)
In-Reply-To: <CAOQ4uxjvkJh2XcfDgj7g+JUkFXEc36_6YOKQHJ=pX2hpGfUDhQ@mail.gmail.com>
On Fri, Jun 18, 2021 at 06:32:18PM +0300, Amir Goldstein wrote:
> On Fri, Jun 18, 2021 at 4:47 PM Christoph Hellwig <hch@infradead.org> wrote:
> >
> > On Thu, Jun 17, 2021 at 10:15:00AM -0700, Darrick J. Wong wrote:
> > > I suppose I could make the '-g' switch call 'make group.list', though
> > > that's just going to increase the amount of noise for anyone like me who
> > > runs fstests with a mostly readonly rootfs.
> >
> > Just stick to the original version and see if anyone screams loud
>
> What is the original version?
Assuming the developer is smart enough to run 'make all install' before
running fstests.
--D
> > enough. Of course the best long-term plan would be to not even generate
> > group files by just calculate the list in-memory.
>
> Why in-memory?
> check already creates $tmp.list with the list of test files right?
> Any reason not to the group.list files under /tmp while preparing
> the test list instead of creating them in the src directory?
>
> Thanks,
> Amir.
next prev parent reply other threads:[~2021-06-18 15:56 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 20:58 [PATCHSET v2 00/13] fstests: move test group lists into test files Darrick J. Wong
2021-06-14 20:59 ` [PATCH 01/13] fstests: fix group check in new script Darrick J. Wong
2021-06-16 5:40 ` Christoph Hellwig
2021-06-14 20:59 ` [PATCH 02/13] misc: move exit status into trap handler Darrick J. Wong
2021-06-16 5:41 ` Christoph Hellwig
2021-06-14 20:59 ` [PATCH 03/13] fstests: refactor test boilerplate code Darrick J. Wong
2021-06-16 5:42 ` Christoph Hellwig
2021-06-16 20:47 ` Eric Biggers
2021-06-17 0:02 ` Darrick J. Wong
2021-06-14 20:59 ` [PATCH 04/13] fstests: add tool migrate group membership data to test files Darrick J. Wong
2021-06-16 7:29 ` Christoph Hellwig
2021-06-14 20:59 ` [PATCH 05/13] fstests: move test group info " Darrick J. Wong
2021-06-16 20:53 ` Eric Biggers
2021-06-14 20:59 ` [PATCH 06/13] fstests: clean up open-coded golden output Darrick J. Wong
2021-06-16 5:45 ` Christoph Hellwig
2021-06-17 0:06 ` Darrick J. Wong
2021-06-14 20:59 ` [PATCH 07/13] fstests: automatically generate group files Darrick J. Wong
2021-06-16 7:32 ` Christoph Hellwig
2021-06-17 0:13 ` Darrick J. Wong
2021-06-17 7:56 ` Christoph Hellwig
2021-06-17 17:15 ` Darrick J. Wong
2021-06-18 13:45 ` Christoph Hellwig
2021-06-18 15:32 ` Amir Goldstein
2021-06-18 15:56 ` Darrick J. Wong [this message]
2021-06-21 5:25 ` Christoph Hellwig
2021-06-21 6:38 ` Eryu Guan
2021-06-21 16:14 ` Darrick J. Wong
2021-06-21 5:20 ` Christoph Hellwig
2021-06-14 20:59 ` [PATCH 08/13] fstests: convert nextid to use automatic group generation Darrick J. Wong
2021-06-16 20:54 ` Eric Biggers
2021-06-14 20:59 ` [PATCH 09/13] fstests: adapt the new test script to our new group tagging scheme Darrick J. Wong
2021-06-14 20:59 ` [PATCH 10/13] check: use generated group files Darrick J. Wong
2021-06-16 20:55 ` Eric Biggers
2021-06-14 20:59 ` [PATCH 11/13] fstests: remove " Darrick J. Wong
2021-06-16 20:56 ` Eric Biggers
2021-06-14 21:00 ` [PATCH 12/13] fstests: remove test group management code Darrick J. Wong
2021-06-16 20:58 ` Eric Biggers
2021-06-17 0:08 ` Darrick J. Wong
2021-06-14 21:00 ` [PATCH 13/13] misc: update documentation to reflect auto-generated group files Darrick J. Wong
2021-06-16 21:00 ` Eric Biggers
2021-06-17 0:11 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2021-06-21 23:10 [PATCHSET v3 00/13] fstests: move test group lists into test files Darrick J. Wong
2021-06-21 23:10 ` [PATCH 07/13] fstests: automatically generate group files Darrick J. Wong
2021-06-08 17:19 [PATCHSET v1 00/13] fstests: move test group lists into test files Darrick J. Wong
2021-06-08 17:20 ` [PATCH 07/13] fstests: automatically generate group files Darrick J. Wong
2021-06-11 5:39 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618155630.GE158209@locust \
--to=djwong@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=amir73il@gmail.com \
--cc=chandanrlinux@gmail.com \
--cc=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox