From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2226CC4743C for ; Mon, 21 Jun 2021 16:58:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F16A760200 for ; Mon, 21 Jun 2021 16:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230377AbhFURAQ (ORCPT ); Mon, 21 Jun 2021 13:00:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:47708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233271AbhFUQ7q (ORCPT ); Mon, 21 Jun 2021 12:59:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8C93E60C3F; Mon, 21 Jun 2021 16:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624294652; bh=SYNdbbqd8hbPZCLmFz7xPj8bzpG3YVpkSkp67e+IHe4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ebLpD3SYV+UD8P1cSPaJEnQTwXGDhd5OjwtNxVegmTPHfYUmM9neOlyXCqfMn/2nt zO2x9L59wEpIwN1JFS8IxSV8sz7cc9OzfaDC/+JJqlcNi/lNnxMDEjwmcenxv5HhpK 9NfkHRkbgd0AvtRfV2VJETrAiiAS+TYwy3SDkliCBAp7Y5DODLycU33J12h/VXt9Dl +3ZQcJerSOMgagQVuIALJgmj5QvMTuixVgqskf3GmIAdyBb3xOa+YFpLteoh67MUEw onzy9j7qgtOkx2pkg25RWcPmzQkejJ2BelPYi6WxazK8hUNjSaUo10CaOATwU0oNuT fvI2NNBQT81KQ== Date: Mon, 21 Jun 2021 09:57:32 -0700 From: "Darrick J. Wong" To: Brian Foster Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH v2 0/2] xfs: fix buffer use after free on unpin abort Message-ID: <20210621165732.GB3619569@locust> References: <20210621131644.128177-1-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210621131644.128177-1-bfoster@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Jun 21, 2021 at 09:16:42AM -0400, Brian Foster wrote: > v2: > - Split assert in patch 2. > v1: https://lore.kernel.org/linux-xfs/20210511135257.878743-1-bfoster@redhat.com/ > - Rework patch 1 to hold conditionally in the abort case and document > the underlying design flaw. > - Add patch 2 to remove some unused code. > rfc: https://lore.kernel.org/linux-xfs/20210503121816.561340-1-bfoster@redhat.com/ > > Brian Foster (2): > xfs: hold buffer across unpin and potential shutdown processing > xfs: remove dead stale buf unpin handling code Doh, this totally fell off my radar. Thanks for resubmitting it, I'll put it in the test queue. --D > > fs/xfs/xfs_buf_item.c | 58 +++++++++++++++++-------------------------- > 1 file changed, 23 insertions(+), 35 deletions(-) > > -- > 2.26.3 >