[PATCH] xfs: fix warnings in compat_ioctl code

[PATCH] xfs: fix warnings in compat_ioctl code

[Darrick J. Wong]

From: Darrick J. Wong <djwong@kernel.org>

Fix some compiler warnings about unused variables.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 fs/xfs/xfs_ioctl32.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_ioctl32.c b/fs/xfs/xfs_ioctl32.c
index e6506773ba55..ebcc342e3bf8 100644
--- a/fs/xfs/xfs_ioctl32.c
+++ b/fs/xfs/xfs_ioctl32.c
@@ -439,7 +439,6 @@ xfs_file_compat_ioctl(
 	struct inode		*inode = file_inode(filp);
 	struct xfs_inode	*ip = XFS_I(inode);
 	void			__user *arg = compat_ptr(p);
-	int			error;
 
 	trace_xfs_file_compat_ioctl(ip);
 
@@ -460,6 +459,7 @@ xfs_file_compat_ioctl(
 		return xfs_compat_ioc_fsgeometry_v1(ip->i_mount, arg);
 	case XFS_IOC_FSGROWFSDATA_32: {
 		struct xfs_growfs_data	in;
+		int			error;
 
 		if (xfs_compat_growfs_data_copyin(&in, arg))
 			return -EFAULT;
@@ -472,6 +472,7 @@ xfs_file_compat_ioctl(
 	}
 	case XFS_IOC_FSGROWFSRT_32: {
 		struct xfs_growfs_rt	in;
+		int			error;
 
 		if (xfs_compat_growfs_rt_copyin(&in, arg))
 			return -EFAULT;

Re: [PATCH] xfs: fix warnings in compat_ioctl code

[Christoph Hellwig]

On Fri, Jul 02, 2021 at 08:01:20PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Fix some compiler warnings about unused variables.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>

The change looks silly but otherwise ok.  What compiler gives these
stupid warnings?

Re: [PATCH] xfs: fix warnings in compat_ioctl code

[Darrick J. Wong]

On Mon, Jul 05, 2021 at 09:43:20AM +0100, Christoph Hellwig wrote:
> On Fri, Jul 02, 2021 at 08:01:20PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > Fix some compiler warnings about unused variables.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> 
> The change looks silly but otherwise ok.  What compiler gives these
> stupid warnings?

gcc 10.3, but it doesn't matter because the kbuild robot says this patch
creates even /more/ silly warnings on other weird architectures, so I'm
withdrawing this patch because I DGAF^W have decided that chasing unused
variable warnings is a bad use of anybody's time.

--D