From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C812AC07E99 for ; Fri, 9 Jul 2021 04:29:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9263B6138C for ; Fri, 9 Jul 2021 04:29:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbhGIEcR (ORCPT ); Fri, 9 Jul 2021 00:32:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:33708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbhGIEcR (ORCPT ); Fri, 9 Jul 2021 00:32:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 93C086141A; Fri, 9 Jul 2021 04:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625804974; bh=3HNn/xpvrZs3tcQEA38VgCXMxppLux+mv+RaiGJT62o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S8NikfcmWmLYq+Tm7M1Flyuykyp8G4aXyYNFZ23Y3tc1Pf3ug0qhLUbg4M4dLRean HdJunqhcBJdDXtvC+KE+k+8JkROEg2rSz7V85mnyzGfFLEHrBrCV9Q8tYTg3cBNrWh P9yOKB/LhfnOzq7yosXNV78BgTCRLqi8apDFYOVv6B48lCeGGDSVACjBfHS4XTkZYW jeaIz8iH+QRf+3vigvmOI+ptxeCHMQCswbxSw79r5WesKlakxE4uWlz6q9AezL6KVX eA/RpHdViYBfh3o+ID6wSgWDfkmfLah98oEF/uS6WVmJubh3sUuyUaUU5w4yDNsr2r lzamKJX/hCMqg== Date: Thu, 8 Jul 2021 21:29:34 -0700 From: "Darrick J. Wong" To: Andreas Gruenbacher Cc: Christoph Hellwig , Matthew Wilcox , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com Subject: Re: [PATCH v3 3/3] iomap: Don't create iomap_page objects in iomap_page_mkwrite_actor Message-ID: <20210709042934.GV11588@locust> References: <20210707115524.2242151-1-agruenba@redhat.com> <20210707115524.2242151-4-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210707115524.2242151-4-agruenba@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Jul 07, 2021 at 01:55:24PM +0200, Andreas Gruenbacher wrote: > Now that we create those objects in iomap_writepage_map when needed, > there's no need to pre-create them in iomap_page_mkwrite_actor anymore. > > Signed-off-by: Andreas Gruenbacher I'd like to stage this series as a bugfix branch against -rc1 next week, if there are no other objections? Reviewed-by: Darrick J. Wong --D > --- > fs/iomap/buffered-io.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 6330dabc451e..9f45050b61dd 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -999,7 +999,6 @@ iomap_page_mkwrite_actor(struct inode *inode, loff_t pos, loff_t length, > block_commit_write(page, 0, length); > } else { > WARN_ON_ONCE(!PageUptodate(page)); > - iomap_page_create(inode, page); > set_page_dirty(page); > } > > -- > 2.26.3 >