Re: [PATCH 2/9] xfs: XLOG_STATE_IOERROR must die

Christoph Hellwig
2021-07-14T06:13:41Z

> @@ -2781,23 +2770,20 @@ xlog_state_do_callback(
> * Keep looping through iclogs until one full pass is made
> * without running any callbacks.
> */
> - first_iclog = log->l_iclog;
> - iclog = log->l_iclog;
> cycled_icloglock = false;
> - ioerror = false;
> - repeats++;
> + first_iclog = log->l_iclog;
> + iclog = first_iclog;
>
> do {

> - } while (first_iclog != iclog);
> + } while (iclog != first_iclog);
>
> - if (repeats > 5000) {
> + if (++repeats > 5000) {

Still various unrelated random reshuffling.

The rest looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>