From: "Darrick J. Wong" <djwong@kernel.org>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
lukas.bulwahn@gmail.com
Subject: Re: [PATCH] fs:xfs: cleanup __FUNCTION__ usage
Date: Wed, 14 Jul 2021 16:27:56 -0700 [thread overview]
Message-ID: <20210714232756.GL22402@magnolia> (raw)
In-Reply-To: <20210711085153.95856-1-dwaipayanray1@gmail.com>
On Sun, Jul 11, 2021 at 02:21:53PM +0530, Dwaipayan Ray wrote:
> __FUNCTION__ exists only for backwards compatibility reasons
> with old gcc versions. Replace it with __func__.
>
> Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
LGTM
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_icreate_item.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_icreate_item.c b/fs/xfs/xfs_icreate_item.c
> index 9b3994b9c716..017904a34c02 100644
> --- a/fs/xfs/xfs_icreate_item.c
> +++ b/fs/xfs/xfs_icreate_item.c
> @@ -201,7 +201,7 @@ xlog_recover_icreate_commit_pass2(
> if (length != igeo->ialloc_blks &&
> length != igeo->ialloc_min_blks) {
> xfs_warn(log->l_mp,
> - "%s: unsupported chunk length", __FUNCTION__);
> + "%s: unsupported chunk length", __func__);
> return -EINVAL;
> }
>
> @@ -209,7 +209,7 @@ xlog_recover_icreate_commit_pass2(
> if ((count >> mp->m_sb.sb_inopblog) != length) {
> xfs_warn(log->l_mp,
> "%s: inconsistent inode count and chunk length",
> - __FUNCTION__);
> + __func__);
> return -EINVAL;
> }
>
> --
> 2.28.0
>
prev parent reply other threads:[~2021-07-14 23:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 8:51 [PATCH] fs:xfs: cleanup __FUNCTION__ usage Dwaipayan Ray
2021-07-11 22:46 ` Dave Chinner
2021-07-14 23:27 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714232756.GL22402@magnolia \
--to=djwong@kernel.org \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox