From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC61C12002 for ; Wed, 14 Jul 2021 23:44:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D66E361026 for ; Wed, 14 Jul 2021 23:44:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237805AbhGNXr1 (ORCPT ); Wed, 14 Jul 2021 19:47:27 -0400 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:47823 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbhGNXr0 (ORCPT ); Wed, 14 Jul 2021 19:47:26 -0400 Received: from dread.disaster.area (pa49-181-34-10.pa.nsw.optusnet.com.au [49.181.34.10]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 9C3E01044F3C; Thu, 15 Jul 2021 09:44:32 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1m3oYJ-006cXO-O3; Thu, 15 Jul 2021 09:44:31 +1000 Date: Thu, 15 Jul 2021 09:44:31 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/2] xfs: improve FSGROWFSRT precondition checking Message-ID: <20210714234431.GD664593@dread.disaster.area> References: <162629791767.487242.2747879614157558075.stgit@magnolia> <162629792325.487242.1728593976863145148.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162629792325.487242.1728593976863145148.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=YKPhNiOx c=1 sm=1 tr=0 a=hdaoRb6WoHYrV466vVKEyw==:117 a=hdaoRb6WoHYrV466vVKEyw==:17 a=kj9zAlcOel0A:10 a=e_q4qTt1xDgA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=JCO9xQgf1TFseN_Av_UA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Jul 14, 2021 at 02:25:23PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Improve the checking at the start of a realtime grow operation so that > we avoid accidentally set a new extent size that is too large and avoid > adding an rt volume to a filesystem with rmap or reflink because we > don't support rt rmap or reflink yet. > > While we're at it, separate the checks so that we're only testing one > aspect at a time. > > Signed-off-by: Darrick J. Wong So improvement. Much nice. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com