From: Christoph Hellwig <hch@lst.de>
To: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: remove support for disabling quota accounting on a mounted file system
Date: Tue, 20 Jul 2021 08:33:49 +0200 [thread overview]
Message-ID: <20210720063349.GA14747@lst.de> (raw)
In-Reply-To: <20210714111049.dxhrtupk46ls4ujb@omega.lan>
On Wed, Jul 14, 2021 at 01:10:49PM +0200, Carlos Maiolino wrote:
> > - mutex_unlock(&q->qi_quotaofflock);
> > - return error;
> > + /* XXX what to do if error ? Revert back to old vals incore ? */
>
> May be too strict, but I wonder if we shouldn't shut the FS down in case we fail
> here?
This is just the existing code being unindented by one level. The
usual transaction commit failure cases will cause a shutdown anyway.
next prev parent reply other threads:[~2021-07-20 6:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 11:14 don't allow disabling quota accounting on a mounted file system Christoph Hellwig
2021-07-12 11:14 ` [PATCH 1/3] xfs: remove support for " Christoph Hellwig
2021-07-14 11:10 ` Carlos Maiolino
2021-07-20 6:33 ` Christoph Hellwig [this message]
2021-07-14 21:44 ` Darrick J. Wong
2021-07-15 17:15 ` Darrick J. Wong
2021-07-20 6:35 ` Christoph Hellwig
2021-07-12 11:14 ` [PATCH 2/3] xfs: remove the flags argument to xfs_qm_dquot_walk Christoph Hellwig
2021-07-14 11:11 ` Carlos Maiolino
2021-07-14 21:45 ` Darrick J. Wong
2021-07-12 11:14 ` [PATCH 3/3] xfs: remove the active vs running quota differentiation Christoph Hellwig
2021-07-14 11:47 ` Carlos Maiolino
2021-07-14 21:47 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2021-07-22 7:26 don't allow disabling quota accounting on a mounted file system v2 Christoph Hellwig
2021-07-22 7:26 ` [PATCH 1/3] xfs: remove support for disabling quota accounting on a mounted file system Christoph Hellwig
2021-07-22 18:22 ` Darrick J. Wong
2021-07-22 19:03 ` Christoph Hellwig
2021-07-22 19:07 ` Darrick J. Wong
2021-07-23 5:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720063349.GA14747@lst.de \
--to=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).