From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/5] xfs: flush data dev on external log write
Date: Thu, 22 Jul 2021 08:52:21 -0700 [thread overview]
Message-ID: <20210722155221.GA8612@magnolia> (raw)
In-Reply-To: <20210722015335.3063274-2-david@fromorbit.com>
On Thu, Jul 22, 2021 at 11:53:31AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> We incorrectly flush the log device instead of the data device when
> trying to ensure metadata is correctly on disk before writing the
> unmount record.
>
> Fixes: eef983ffeae7 ("xfs: journal IO cache flush reductions")
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
DOH
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 36fa2650b081..96434cc4df6e 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -833,7 +833,7 @@ xlog_write_unmount_record(
> * stamp the tail LSN into the unmount record.
> */
> if (log->l_targ != log->l_mp->m_ddev_targp)
> - blkdev_issue_flush(log->l_targ->bt_bdev);
> + blkdev_issue_flush(log->l_mp->m_ddev_targp->bt_bdev);
> return xlog_write(log, &vec, ticket, NULL, NULL, XLOG_UNMOUNT_TRANS);
> }
>
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-07-22 15:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 1:53 [PATCH 0/5] xfs: fix log cache flush regressions Dave Chinner
2021-07-22 1:53 ` [PATCH 1/5] xfs: flush data dev on external log write Dave Chinner
2021-07-22 6:41 ` Christoph Hellwig
2021-07-22 15:52 ` Darrick J. Wong [this message]
2021-07-22 1:53 ` [PATCH 2/5] xfs: external logs need to flush data device Dave Chinner
2021-07-22 6:48 ` Christoph Hellwig
2021-07-22 18:14 ` Darrick J. Wong
2021-07-22 21:45 ` Dave Chinner
2021-07-22 23:10 ` Darrick J. Wong
2021-07-22 1:53 ` [PATCH 3/5] xfs: fix ordering violation between cache flushes and tail updates Dave Chinner
2021-07-22 7:06 ` Christoph Hellwig
2021-07-22 7:28 ` Dave Chinner
2021-07-22 19:12 ` Darrick J. Wong
2021-07-22 1:53 ` [PATCH 4/5] xfs: log forces imply data device cache flushes Dave Chinner
2021-07-22 7:14 ` Christoph Hellwig
2021-07-22 7:32 ` Dave Chinner
2021-07-22 19:30 ` Darrick J. Wong
2021-07-22 22:12 ` Dave Chinner
2021-07-22 23:13 ` Darrick J. Wong
2021-07-22 1:53 ` [PATCH 5/5] xfs: avoid unnecessary waits in xfs_log_force_lsn() Dave Chinner
2021-07-22 7:15 ` Christoph Hellwig
2021-07-22 19:13 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210722155221.GA8612@magnolia \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox