From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 8/7] xfs/152: avoid failure when quotaoff is not supported
Date: Thu, 22 Jul 2021 22:08:59 -0700 [thread overview]
Message-ID: <20210723050859.GR559212@magnolia> (raw)
In-Reply-To: <20210722073832.976547-1-hch@lst.de>
From: Darrick J. Wong <djwong@kernel.org>
Switch the test that removes the quota files to just disable enforcement
and then unmount the file system as disabling quota accounting is about
to go away.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
tests/xfs/152 | 20 +++++++++++++-------
tests/xfs/152.out | 4 ----
2 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/tests/xfs/152 b/tests/xfs/152
index de85f48c..129d9c06 100755
--- a/tests/xfs/152
+++ b/tests/xfs/152
@@ -195,8 +195,9 @@ test_enable()
test_off()
{
echo "checking off command (type=$type)"
- $XFS_QUOTA_PROG -D $tmp.projects -P $tmp.projid -x \
- -c "off -$type -v" $SCRATCH_MNT | _filter_scratch
+ _scratch_unmount
+ _qmount_option ""
+ _qmount
}
test_remove()
@@ -257,6 +258,8 @@ qmount_idmapped()
test_xfs_quota()
{
+ local quota_options="$1"
+
# init quota
echo "init quota limit and timer, and dump it"
if [ "$idmapped" -eq 1 ]; then
@@ -310,7 +313,10 @@ test_xfs_quota()
echo ; test_state
echo ; test_remove
echo ; test_report -N
- echo "quota remount"; qmount_idmapped
+ echo "quota remount"
+ _qmount_option "$quota_options"
+ _qmount
+ qmount_idmapped
echo ; test_report -N
# restore test
@@ -329,7 +335,7 @@ id=$uqid
id2=$uqid2
idmapped=0
qmount_idmapped
-test_xfs_quota
+test_xfs_quota "uquota,sync"
echo "----------------------- uquota,sync,idmapped ---------------------------"
wipe_scratch
@@ -339,7 +345,7 @@ id=$uqid
id2=$uqid2
idmapped=1
qmount_idmapped
-test_xfs_quota
+test_xfs_quota "uquota,sync"
echo "----------------------- gquota,sync,unmapped ---------------------------"
wipe_scratch
@@ -349,7 +355,7 @@ id=$gqid
id2=$gqid2
idmapped=0
qmount_idmapped
-test_xfs_quota
+test_xfs_quota "gquota,sync"
echo "----------------------- gquota,sync,idmapped ---------------------------"
wipe_scratch
@@ -359,7 +365,7 @@ id=$gqid
id2=$gqid2
idmapped=1
qmount_idmapped
-test_xfs_quota
+test_xfs_quota "gquota,sync"
wipe_mounts
diff --git a/tests/xfs/152.out b/tests/xfs/152.out
index 1fc71fb9..b663b096 100644
--- a/tests/xfs/152.out
+++ b/tests/xfs/152.out
@@ -132,7 +132,6 @@ checking quota command (type=u)
SCRATCH_DEV 1024 102400 102400 00 [--------] 15 100 100 00 [--------] SCRATCH_MNT
checking off command (type=u)
-User quota are not enabled on SCRATCH_DEV
checking state command (type=u)
@@ -296,7 +295,6 @@ checking quota command (type=u)
SCRATCH_DEV 1024 102400 102400 00 [--------] 15 100 100 00 [--------] SCRATCH_MNT
checking off command (type=u)
-User quota are not enabled on SCRATCH_DEV
checking state command (type=u)
@@ -460,7 +458,6 @@ checking quota command (type=g)
SCRATCH_DEV 1024 102400 102400 00 [--------] 15 100 100 00 [--------] SCRATCH_MNT
checking off command (type=g)
-Group quota are not enabled on SCRATCH_DEV
checking state command (type=g)
@@ -624,7 +621,6 @@ checking quota command (type=g)
SCRATCH_DEV 1024 102400 102400 00 [--------] 15 100 100 00 [--------] SCRATCH_MNT
checking off command (type=g)
-Group quota are not enabled on SCRATCH_DEV
checking state command (type=g)
next prev parent reply other threads:[~2021-07-23 5:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 7:38 prepare for removing support to disable quota accounting v2 Christoph Hellwig
2021-07-22 7:38 ` [PATCH 1/7] common/quota: allow removing quota options entirely in _qmount_option Christoph Hellwig
2021-07-22 7:38 ` [PATCH 2/7] xfs/007: unmount after disabling quota Christoph Hellwig
2021-07-22 7:38 ` [PATCH 3/7] xfs/106: don't test disabling quota accounting Christoph Hellwig
2021-07-22 18:23 ` Darrick J. Wong
2021-07-22 7:38 ` [PATCH 4/7] xfs/220: avoid failure when disabling quota accounting is not supported Christoph Hellwig
2021-07-22 18:24 ` Darrick J. Wong
2021-07-22 7:38 ` [PATCH 5/7] xfs/304: don't turn quota accounting off Christoph Hellwig
2021-07-22 7:38 ` [PATCH 6/7] xfs/305: " Christoph Hellwig
2021-07-22 7:38 ` [PATCH 7/7] xfs: use $XFS_QUOTA_PROG instead of hardcoding xfs_quota Christoph Hellwig
2021-07-22 18:25 ` Darrick J. Wong
2021-07-22 23:17 ` Darrick J. Wong
2021-07-25 15:02 ` Eryu Guan
2021-07-23 5:08 ` Darrick J. Wong [this message]
2021-07-23 5:10 ` [PATCH 8/7] xfs/152: avoid failure when quotaoff is not supported Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723050859.GR559212@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).