From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3AF9C432BE for ; Tue, 27 Jul 2021 22:17:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D305F60F9B for ; Tue, 27 Jul 2021 22:17:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232359AbhG0WR0 (ORCPT ); Tue, 27 Jul 2021 18:17:26 -0400 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:44050 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232223AbhG0WR0 (ORCPT ); Tue, 27 Jul 2021 18:17:26 -0400 Received: from dread.disaster.area (pa49-181-34-10.pa.nsw.optusnet.com.au [49.181.34.10]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id F106C104522A; Wed, 28 Jul 2021 08:17:23 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1m8VO6-00BWx4-UH; Wed, 28 Jul 2021 08:17:22 +1000 Date: Wed, 28 Jul 2021 08:17:22 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: Eric Sandeen , xfs Subject: Re: [PATCH] xfs_repair: invalidate dirhash entry when junking dirent Message-ID: <20210727221722.GW664593@dread.disaster.area> References: <20210727191611.GI559212@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210727191611.GI559212@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=YKPhNiOx c=1 sm=1 tr=0 a=hdaoRb6WoHYrV466vVKEyw==:117 a=hdaoRb6WoHYrV466vVKEyw==:17 a=kj9zAlcOel0A:10 a=e_q4qTt1xDgA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=8DDc4FTjGkHsdxAYwHIA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Jul 27, 2021 at 12:16:11PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > In longform_dir2_entry_check_data, we add the directory entries we find > to the incore dirent hash table after we've validated the name but > before we're totally done checking the entry. This sequence is > necessary to detect all duplicated names in the directory. > > Unfortunately, if we later decide to junk the ondisk dirent, we neglect > to mark the dirhash entry, so if the directory gets rebuilt, it will get > rebuilt with the entry that we rejected. > > Signed-off-by: Darrick J. Wong Makes sense. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com