Re: [PATCH 11/14] xfs: don't run speculative preallocation gc when fs is frozen

Dave Chinner
2021-08-05T05:40:39Z

On Wed, Aug 04, 2021 at 07:07:23PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Now that we have the infrastructure to switch background workers on and
> off at will, fix the block gc worker code so that we don't actually run
> the worker when the filesystem is frozen, same as we do for deferred
> inactivation.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/scrub/common.c | 9 +++++----
> fs/xfs/xfs_icache.c | 27 +++++++++++++++++++++++----
> fs/xfs/xfs_mount.c | 1 +
> fs/xfs/xfs_mount.h | 8 ++++++++
> fs/xfs/xfs_super.c | 9 ++++++---
> fs/xfs/xfs_trace.h | 6 +++++-
> 6 files changed, 48 insertions(+), 12 deletions(-)

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com