Re: [PATCH 07/14] xfs: queue inactivation immediately when quota is nearing enforcement

Dave Chinner
2021-08-05T05:35:03Z

On Wed, Aug 04, 2021 at 07:07:01PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Now that we have made the inactivation of unlinked inodes a background
> task to increase the throughput of file deletions, we need to be a
> little more careful about how long of a delay we can tolerate.
>
> Specifically, if the dquots attached to the inode being inactivated are
> nearing any kind of enforcement boundary, we want to queue that
> inactivation work immediately so that users don't get EDQUOT/ENOSPC
> errors even after they deleted a bunch of files to stay within quota.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/xfs_dquot.h | 10 ++++++++++
> fs/xfs/xfs_icache.c | 10 ++++++++++
> fs/xfs/xfs_qm.c | 34 ++++++++++++++++++++++++++++++++++
> fs/xfs/xfs_quota.h | 2 ++
> 4 files changed, 56 insertions(+)

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com