From: "Darrick J. Wong" <djwong@kernel.org>
To: Pavel Reichl <preichl@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: remove the xfs_dinode_t typedef
Date: Thu, 12 Aug 2021 10:16:13 -0700 [thread overview]
Message-ID: <20210812171613.GT3601443@magnolia> (raw)
In-Reply-To: <6d28d82c-4113-3b74-c7bd-f430cf8fbfb3@redhat.com>
On Thu, Aug 12, 2021 at 11:31:31AM +0200, Pavel Reichl wrote:
>
> On 8/12/21 10:43 AM, Christoph Hellwig wrote:
> > /*
> > * If the size is unreasonable, then something
> > @@ -162,8 +162,8 @@ xfs_iformat_extents(
> > */
> > STATIC int
> > xfs_iformat_btree(
> > - xfs_inode_t *ip,
> > - xfs_dinode_t *dip,
> > + struct xfs_inode *ip,
> > + struct xfs_dinode *dip,
> > int whichfork)
>
> Hi,
>
> since you are also removing xfs_inode_t I'd like to ask if it is a good idea
[assuming you meant xfs_dinode_t here]
> to send a separate patch removing all other instances of xfs_inode_t? (I'm
> happy to do it).
Seems like a reasonable thing to me.
--D
>
> Patch applies, builds and LGTM.
>
> Reviewed-by: Pavel Reichl <preichl@redhat.com>
>
next prev parent reply other threads:[~2021-08-12 17:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 8:43 misc typedef removal Christoph Hellwig
2021-08-12 8:43 ` [PATCH 1/3] xfs: remove the xfs_dinode_t typedef Christoph Hellwig
2021-08-12 9:31 ` Pavel Reichl
2021-08-12 17:16 ` Darrick J. Wong [this message]
2021-08-12 18:41 ` Pavel Reichl
2021-08-12 18:44 ` Darrick J. Wong
2021-08-12 17:14 ` Darrick J. Wong
2021-08-12 21:13 ` Dave Chinner
2021-08-12 8:43 ` [PATCH 2/3] xfs: remove the xfs_dsb_t typedef Christoph Hellwig
2021-08-12 9:25 ` Pavel Reichl
2021-08-12 12:13 ` Alex Elder
2021-08-12 17:14 ` Darrick J. Wong
2021-08-12 8:43 ` [PATCH 3/3] xfs: remove the xfs_dqblk_t typedef Christoph Hellwig
2021-08-12 9:25 ` Pavel Reichl
2021-08-12 12:13 ` Alex Elder
2021-08-12 17:16 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812171613.GT3601443@magnolia \
--to=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox