From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1545C4338F for ; Thu, 12 Aug 2021 21:13:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C2D760F57 for ; Thu, 12 Aug 2021 21:13:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235246AbhHLVNt (ORCPT ); Thu, 12 Aug 2021 17:13:49 -0400 Received: from mail108.syd.optusnet.com.au ([211.29.132.59]:44207 "EHLO mail108.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231270AbhHLVNt (ORCPT ); Thu, 12 Aug 2021 17:13:49 -0400 Received: from dread.disaster.area (pa49-195-182-146.pa.nsw.optusnet.com.au [49.195.182.146]) by mail108.syd.optusnet.com.au (Postfix) with ESMTPS id E50DD1B50FD; Fri, 13 Aug 2021 07:13:21 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1mEI0u-00HacL-Oc; Fri, 13 Aug 2021 07:13:20 +1000 Date: Fri, 13 Aug 2021 07:13:20 +1000 From: Dave Chinner To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/3] xfs: remove the xfs_dinode_t typedef Message-ID: <20210812211320.GD3657114@dread.disaster.area> References: <20210812084343.27934-1-hch@lst.de> <20210812084343.27934-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210812084343.27934-2-hch@lst.de> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=Tu+Yewfh c=1 sm=1 tr=0 a=QpfB3wCSrn/dqEBSktpwZQ==:117 a=QpfB3wCSrn/dqEBSktpwZQ==:17 a=kj9zAlcOel0A:10 a=MhDmnRu9jo8A:10 a=7-415B0cAAAA:8 a=sWdXBT-FfqaZGUN-yIwA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Aug 12, 2021 at 10:43:41AM +0200, Christoph Hellwig wrote: > Remove the few leftover instances of the xfs_dinode_t typedef. > > Signed-off-by: Christoph Hellwig True for the kernel, but there are: $ git grep xfs_dinode_t |wc -l 126 A *lot* of userspace uses of this typedef. So either the typedef stays defined in libxfs, or this also needs a patch for the removal of the typedef from xfsprogs as well. Cheers, Dave. -- Dave Chinner david@fromorbit.com