Re: [PATCH 7/9] tools: add missing license tags to my scripts

Darrick J. Wong
2021-09-16T21:44:59Z

On Thu, Sep 16, 2021 at 09:06:38AM +0300, Amir Goldstein wrote:
> On Thu, Sep 16, 2021 at 2:43 AM Darrick J. Wong <djwong@kernel.org> wrote:
> >
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > I forgot to add spdx license tags and copyright statements to some of
> > the tools that I've contributed to fstests. Fix this to be explicit.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
>
> Is someone having an identity crisis? :-P

No, just an IT crisis. @oracle.com is now exchange cloud, hence me
moving to kernel.org mail forwarding. For licensing things I want to
make it clear that someone from oracle is adding an oracle copyright
statement.

--D

> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
>
> > ---
> > common/preamble | 21 ++++++++
> > doc/group-names.txt | 135 +++++++++++++++++++++++++++++++++++++++++++++++++++
> > tools/mkgroupfile | 33 +++++++++---
> > 3 files changed, 181 insertions(+), 8 deletions(-)
> > create mode 100644 doc/group-names.txt
> >
> >
> > diff
> > ---
> > tools/mkgroupfile | 4 +++-
> > tools/mvtest | 5 ++++-
> > tools/nextid | 4 +++-
> > 3 files changed, 10 insertions(+), 3 deletions(-)
> >
> >
> > diff --git a/tools/mkgroupfile b/tools/mkgroupfile
> > index e4244507..634ec92c 100755
> > --- a/tools/mkgroupfile
> > +++ b/tools/mkgroupfile
> > @@ -1,5 +1,7 @@
> > #!/bin/bash
> > -
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2021 Oracle. All Rights Reserved.
> > +#
> > # Generate a group file from the _begin_fstest call in each test.
> >
> > if [ "$1" = "--help" ]; then
> > diff --git a/tools/mvtest b/tools/mvtest
> > index 5088b45f..99b15414 100755
> > --- a/tools/mvtest
> > +++ b/tools/mvtest
> > @@ -1,6 +1,9 @@
> > #!/bin/sh
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2015 Oracle. All Rights Reserved.
> > +#
>
> [...]
>
> > diff --git a/tools/nextid b/tools/nextid
> > index 9507de29..9e31718c 100755
> > --- a/tools/nextid
> > +++ b/tools/nextid
> > @@ -1,5 +1,7 @@
> > #!/bin/bash
> > -
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2015 Oracle. All Rights Reserved.
> > +#
>
> I suppose 2015 is intentional?
> Should it be 2015-2021? I have no idea what the legal implications
> are, but anyway, very low probability that those scripts would end up
> in litigation :)
>
> Thanks,
> Amir.