From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CACEC433EF for ; Fri, 17 Sep 2021 16:00:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A78E61100 for ; Fri, 17 Sep 2021 16:00:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229840AbhIQQBX (ORCPT ); Fri, 17 Sep 2021 12:01:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:51946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbhIQQBX (ORCPT ); Fri, 17 Sep 2021 12:01:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 255B661019; Fri, 17 Sep 2021 16:00:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631894401; bh=5ajiJ7iHk5eR9Bt5z3D/ZQHJwfEgy4mmvqGfWLY2BFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RWE31FD47PGp3YPi66J7WgrniAXZDN3KZTisQ6rk2akztof5zYLI8gAcv7prTzmNo 45j0Zdwn+jtLU+tbhlHMxGzL5FTUW/dUvy/bJqhCkkoucsimQYrwB8HmoXhtmjBYQ2 JLrmTgy81XF8yz60+DS53EYX47Lfuv/bpWkDMaC5AFQ3QqnnsAMCvF11CxzLZQkvZo fpsMZKj7Pexd7DzuMYpmV2a/cShnquYfHdj5lE7UlHaumMoMXTbRXILwNKlK1K/8js krmmLC2uKX7YsESA9luoOejpI0+yM3CDTgySWPPodIxstv8lgIlZPU8q8tB5mAY+NN wFTqJeo2LKXyQ== Date: Fri, 17 Sep 2021 09:00:00 -0700 From: "Darrick J. Wong" To: Amir Goldstein Cc: Eryu Guan , linux-xfs , fstests , Eryu Guan Subject: Re: [PATCH 9/9] new: don't allow new tests in group 'other' Message-ID: <20210917160000.GA10224@magnolia> References: <163174935747.380880.7635671692624086987.stgit@magnolia> <163174940659.380880.14564845266535022734.stgit@magnolia> <20210916225306.GB34846@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Fri, Sep 17, 2021 at 05:31:25AM +0300, Amir Goldstein wrote: > On Fri, Sep 17, 2021 at 1:53 AM Darrick J. Wong wrote: > > > > On Thu, Sep 16, 2021 at 09:40:54AM +0300, Amir Goldstein wrote: > > > On Thu, Sep 16, 2021 at 2:43 AM Darrick J. Wong wrote: > > > > > > > > From: Darrick J. Wong > > > > > > > > The 'other' group is vaguely defined at best -- other than what? It's > > > > not clear what tests belong in this group, and it has become a dumping > > > > ground for random stuff that are classified in other groups. Don't let > > > > people create new other group tests. > > > > > > > > Signed-off-by: Darrick J. Wong > > > > --- > > > > new | 7 +++++-- > > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/new b/new > > > > index 6b7dc5d4..5cf96c50 100755 > > > > --- a/new > > > > +++ b/new > > > > @@ -96,9 +96,9 @@ then > > > > > > > > while true > > > > do > > > > - echo -n "Add to group(s) [other] (separate by space, ? for list): " > > > > + echo -n "Add to group(s) [auto] (separate by space, ? for list): " > > > > read ans > > > > - [ -z "$ans" ] && ans=other > > > > + [ -z "$ans" ] && ans=auto > > > > if [ "X$ans" = "X?" ] > > > > then > > > > echo $(group_names) > > > > @@ -109,6 +109,9 @@ then > > > > echo "Invalid characters in group(s): $inval" > > > > echo "Only lower cases, digits and underscore are allowed in groups, separated by space" > > > > continue > > > > + elif echo "$ans" | grep -q -w "other"; then > > > > + echo "Do not add more tests to group \"other\"." > > > > + continue > > > > > > Should we also filter out "other" from group_names(), so it is not listed > > > for "?"? > > > > No; there are drawbacks to that, as you point out below. > > > > > With this patch, "other" does not emit a warning when passed in as a script > > > command line argument. > > > > Done. > > > > > If we filter "other" from group_names(), then the warning in "expert mode" > > > will be a bit confusing (group "other" not defined in documentation). > > > > I will filter it out in the specific case case that the interactive user > > specified "?" to list the groups. > > > > > Also, it is not clear to me if this is intentional behavior that interactive > > > mode allows non-dcumented groups (with valid chars validation) and > > > expert mode does not allow non-documented groups? > > > > Probably not. > > > > > It may be simpler to use the same helper in both modes (is_group_valid) > > > to emit the correct warning and either proceed (expert mode) or get > > > back to prompt (interactive mode). > > > > This is getting farther afield from where I wanted this thing to go. > > Very well, I'll split the ./new cleanups into its own series, but TBH > > I've gotten tired of people asking for more and more cleanups out of me. > > > > Fair enough. > TBH I just wanted to point out the inconsistencies that I noticed. > I don't really mind if they are fixed. > I should have been more clear about this point. Oh. Well thank you for reviewing this series and the ./new cleanups. :) --D > Thanks, > Amir.