From: Brian Foster <bfoster@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v2 1/4] xfs: fold perag loop iteration logic into helper function
Date: Tue, 12 Oct 2021 12:52:00 -0400 [thread overview]
Message-ID: <20211012165203.1354826-2-bfoster@redhat.com> (raw)
In-Reply-To: <20211012165203.1354826-1-bfoster@redhat.com>
Fold the loop iteration logic into a helper in preparation for
further fixups. No functional change in this patch.
Signed-off-by: Brian Foster <bfoster@redhat.com>
---
fs/xfs/libxfs/xfs_ag.h | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_ag.h b/fs/xfs/libxfs/xfs_ag.h
index 4c6f9045baca..48eb22e8d717 100644
--- a/fs/xfs/libxfs/xfs_ag.h
+++ b/fs/xfs/libxfs/xfs_ag.h
@@ -124,12 +124,22 @@ void xfs_perag_put(struct xfs_perag *pag);
* for_each_perag_from() because they terminate at sb_agcount where there are
* no perag structures in tree beyond end_agno.
*/
+static inline
+struct xfs_perag *xfs_perag_next(
+ struct xfs_perag *pag,
+ xfs_agnumber_t *next_agno)
+{
+ struct xfs_mount *mp = pag->pag_mount;
+
+ *next_agno = pag->pag_agno + 1;
+ xfs_perag_put(pag);
+ return xfs_perag_get(mp, *next_agno);
+}
+
#define for_each_perag_range(mp, next_agno, end_agno, pag) \
for ((pag) = xfs_perag_get((mp), (next_agno)); \
(pag) != NULL && (next_agno) <= (end_agno); \
- (next_agno) = (pag)->pag_agno + 1, \
- xfs_perag_put(pag), \
- (pag) = xfs_perag_get((mp), (next_agno)))
+ (pag) = xfs_perag_next((pag), &(next_agno)))
#define for_each_perag_from(mp, next_agno, pag) \
for_each_perag_range((mp), (next_agno), (mp)->m_sb.sb_agcount, (pag))
--
2.31.1
next prev parent reply other threads:[~2021-10-12 16:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 16:51 [PATCH v2 0/4] xfs: fix perag iteration raciness Brian Foster
2021-10-12 16:52 ` Brian Foster [this message]
2021-10-12 18:53 ` [PATCH v2 1/4] xfs: fold perag loop iteration logic into helper function Darrick J. Wong
2021-10-12 16:52 ` [PATCH v2 2/4] xfs: rename the next_agno perag iteration variable Brian Foster
2021-10-12 18:54 ` Darrick J. Wong
2021-10-12 16:52 ` [PATCH v2 3/4] xfs: terminate perag iteration reliably on agcount Brian Foster
2021-10-12 19:08 ` Darrick J. Wong
2021-10-14 14:10 ` Brian Foster
2021-10-14 16:46 ` Darrick J. Wong
2021-10-14 17:41 ` Brian Foster
2021-10-14 17:50 ` Darrick J. Wong
2021-10-12 16:52 ` [PATCH v2 4/4] xfs: fix perag reference leak on iteration race with growfs Brian Foster
2021-10-12 19:09 ` Darrick J. Wong
2021-10-12 21:26 ` [PATCH v2 0/4] xfs: fix perag iteration raciness Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012165203.1354826-2-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).