From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 976D9C433F5 for ; Wed, 13 Oct 2021 05:38:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75A6160FDA for ; Wed, 13 Oct 2021 05:38:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229524AbhJMFkp (ORCPT ); Wed, 13 Oct 2021 01:40:45 -0400 Received: from mail109.syd.optusnet.com.au ([211.29.132.80]:48385 "EHLO mail109.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237566AbhJMFko (ORCPT ); Wed, 13 Oct 2021 01:40:44 -0400 Received: from dread.disaster.area (pa49-195-238-16.pa.nsw.optusnet.com.au [49.195.238.16]) by mail109.syd.optusnet.com.au (Postfix) with ESMTPS id 4785B8C0EB; Wed, 13 Oct 2021 16:38:40 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1maWyN-005eqq-NF; Wed, 13 Oct 2021 16:38:39 +1100 Date: Wed, 13 Oct 2021 16:38:39 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, chandan.babu@oracle.com, hch@lst.de Subject: Re: [PATCH 08/15] xfs: encode the max btree height in the cursor Message-ID: <20211013053839.GA2361455@dread.disaster.area> References: <163408155346.4151249.8364703447365270670.stgit@magnolia> <163408159784.4151249.6976364349258667730.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163408159784.4151249.6976364349258667730.stgit@magnolia> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=epq8cqlX c=1 sm=1 tr=0 ts=616670e0 a=DzKKRZjfViQTE5W6EVc0VA==:117 a=DzKKRZjfViQTE5W6EVc0VA==:17 a=kj9zAlcOel0A:10 a=8gfv0ekSlNoA:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=IeGHmyfFkSczZUC025YA:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Oct 12, 2021 at 04:33:17PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Encode the maximum btree height in the cursor, since we're soon going to > allow smaller cursors for AG btrees and larger cursors for file btrees. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/libxfs/xfs_bmap.c | 2 +- > fs/xfs/libxfs/xfs_btree.c | 4 ++-- > fs/xfs/libxfs/xfs_btree.h | 2 ++ > fs/xfs/libxfs/xfs_btree_staging.c | 10 +++++----- > 4 files changed, 10 insertions(+), 8 deletions(-) Looks ok, and fills part of the hole in the btree cursor structure so doesn't grow it again. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com