From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, chandan.babu@oracle.com, hch@lst.de
Subject: Re: [PATCH 11/17] xfs: rename m_ag_maxlevels to m_allocbt_maxlevels
Date: Thu, 14 Oct 2021 17:44:00 -0700 [thread overview]
Message-ID: <20211015004400.GP24307@magnolia> (raw)
In-Reply-To: <20211014225210.GQ2361455@dread.disaster.area>
On Fri, Oct 15, 2021 at 09:52:10AM +1100, Dave Chinner wrote:
> On Thu, Oct 14, 2021 at 01:17:55PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Years ago when XFS was thought to be much more simple, we introduced
> > m_ag_maxlevels to specify the maximum btree height of per-AG btrees for
> > a given filesystem mount. Then we observed that inode btrees don't
> > actually have the same height and split that off; and now we have rmap
> > and refcount btrees with much different geometries and separate
> > maxlevels variables.
> >
> > The 'ag' part of the name doesn't make much sense anymore, so rename
> > this to m_allocbt_maxlevels to reinforce that this is the maximum height
> ^^
> You named it m_alloc_maxlevels....
Oops, fixed.
--D
> > of the *free space* btrees. This sets us up for the next patch, which
> > will add a variable to track the maximum height of all AG btrees.
> >
> > (Also take the opportunity to improve adjacent comments and fix minor
> > style problems.)
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> > fs/xfs/libxfs/xfs_alloc.c | 19 +++++++++++--------
> > fs/xfs/libxfs/xfs_alloc.h | 2 +-
> > fs/xfs/libxfs/xfs_alloc_btree.c | 4 ++--
> > fs/xfs/libxfs/xfs_trans_resv.c | 2 +-
> > fs/xfs/libxfs/xfs_trans_space.h | 2 +-
> > fs/xfs/scrub/agheader.c | 4 ++--
> > fs/xfs/scrub/agheader_repair.c | 4 ++--
> > fs/xfs/xfs_mount.h | 4 ++--
> > 8 files changed, 22 insertions(+), 19 deletions(-)
>
> Other than that minor nit, the change looks good.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
> --
> Dave Chinner
> david@fromorbit.com
next prev parent reply other threads:[~2021-10-15 0:44 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 20:16 [PATCHSET v4 00/17] xfs: support dynamic btree cursor height Darrick J. Wong
2021-10-14 20:17 ` [PATCH 01/17] xfs: fix incorrect decoding in xchk_btree_cur_fsbno Darrick J. Wong
2021-10-14 22:48 ` Dave Chinner
2021-10-14 23:05 ` Darrick J. Wong
2021-10-14 23:17 ` Dave Chinner
2021-10-15 0:37 ` Darrick J. Wong
2021-10-15 0:42 ` [PATCH v4.1 " Darrick J. Wong
2021-10-18 22:26 ` Dave Chinner
2021-10-14 20:17 ` [PATCH 02/17] xfs: remove xfs_btree_cur.bc_blocklog Darrick J. Wong
2021-10-14 20:17 ` [PATCH 03/17] xfs: reduce the size of nr_ops for refcount btree cursors Darrick J. Wong
2021-10-14 20:17 ` [PATCH 04/17] xfs: don't track firstrec/firstkey separately in xchk_btree Darrick J. Wong
2021-10-14 20:17 ` [PATCH 05/17] xfs: dynamically allocate btree scrub context structure Darrick J. Wong
2021-10-14 22:48 ` Dave Chinner
2021-10-14 20:17 ` [PATCH 06/17] xfs: prepare xfs_btree_cur for dynamic cursor heights Darrick J. Wong
2021-10-14 22:49 ` Dave Chinner
2021-10-14 20:17 ` [PATCH 07/17] xfs: rearrange xfs_btree_cur fields for better packing Darrick J. Wong
2021-10-14 20:17 ` [PATCH 08/17] xfs: refactor btree cursor allocation function Darrick J. Wong
2021-10-14 20:17 ` [PATCH 09/17] xfs: encode the max btree height in the cursor Darrick J. Wong
2021-10-14 20:17 ` [PATCH 10/17] xfs: dynamically allocate cursors based on maxlevels Darrick J. Wong
2021-10-14 20:17 ` [PATCH 11/17] xfs: rename m_ag_maxlevels to m_allocbt_maxlevels Darrick J. Wong
2021-10-14 22:52 ` Dave Chinner
2021-10-15 0:44 ` Darrick J. Wong [this message]
2021-10-14 20:18 ` [PATCH 12/17] xfs: compute maximum AG btree height for critical reservation calculation Darrick J. Wong
2021-10-14 22:54 ` Dave Chinner
2021-10-15 0:44 ` Darrick J. Wong
2021-10-14 20:18 ` [PATCH 13/17] xfs: clean up xfs_btree_{calc_size,compute_maxlevels} Darrick J. Wong
2021-10-14 22:58 ` Dave Chinner
2021-10-14 20:18 ` [PATCH 14/17] xfs: compute the maximum height of the rmap btree when reflink enabled Darrick J. Wong
2021-10-14 23:03 ` Dave Chinner
2021-10-15 0:48 ` Darrick J. Wong
2021-10-14 20:18 ` [PATCH 15/17] xfs: kill XFS_BTREE_MAXLEVELS Darrick J. Wong
2021-10-14 20:18 ` [PATCH 16/17] xfs: compute absolute maximum nlevels for each btree type Darrick J. Wong
2021-10-14 23:08 ` Dave Chinner
2021-10-14 20:18 ` [PATCH 17/17] xfs: use separate btree cursor cache " Darrick J. Wong
2021-10-14 23:11 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015004400.GP24307@magnolia \
--to=djwong@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).