From: "Darrick J. Wong" <djwong@kernel.org>
To: xfs <linux-xfs@vger.kernel.org>
Cc: Wengang Wang <wen.gang.wang@oracle.com>
Subject: [PATCH] design: fix computation of buffer log item bitmap size
Date: Tue, 9 Nov 2021 17:58:20 -0800 [thread overview]
Message-ID: <20211110015820.GX24307@magnolia> (raw)
From: Darrick J. Wong <djwong@kernel.org>
Wengang Wang was trying to work through a buffer log item by consulting
the ondisk format documentation, and was confused by the formula given
in section 14.3.14 regarding the size of blf_data_map, aka the dirty
bitmap for buffer log items. We noticed that the documentation doesn't
match what the kernel actually does, so let's fix this.
Reported-by: Wengang Wang <wen.gang.wang@oracle.com>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
.../journaling_log.asciidoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/design/XFS_Filesystem_Structure/journaling_log.asciidoc b/design/XFS_Filesystem_Structure/journaling_log.asciidoc
index 1dba56e..894d3e5 100644
--- a/design/XFS_Filesystem_Structure/journaling_log.asciidoc
+++ b/design/XFS_Filesystem_Structure/journaling_log.asciidoc
@@ -992,7 +992,7 @@ The size of +blf_data_map+, in 32-bit words.
This variable-sized array acts as a dirty bitmap for the logged buffer. Each
1 bit represents a dirty region in the buffer, and each run of 1 bits
corresponds to a subsequent log item containing the new contents of the buffer
-area. Each bit represents +(blf_len * 512) / (blf_map_size * NBBY)+ bytes.
+area. Each bit represents +(blf_len * 512) / (blf_map_size * sizeof(unsigned int) * NBBY)+ bytes.
[[Buffer_Data_Log_Item]]
=== Buffer Data Log Item
next reply other threads:[~2021-11-10 1:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 1:58 Darrick J. Wong [this message]
2021-12-22 22:08 ` [PATCH] design: fix computation of buffer log item bitmap size Darrick J. Wong
2021-12-23 6:06 ` Chandan Babu R
2022-01-04 1:44 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110015820.GX24307@magnolia \
--to=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=wen.gang.wang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox